1039579 - CrashReporterParent::NotifyCrashService should always be on the main thread

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Benjamin Smedberg]

Currently CrashReporterParent assumes that crashes are notified on the main thread, which is true for content/plugins, but is not true of GMP plugins where the entire IPDL setup is on the GMP thread.

The patch here will just proxy the crash-manager bits to the main thread.

Comment 1

[Benjamin Smedberg]

Attachment: bug1039579-CrashReporterParent

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 8456970 [details] [diff] [review]
bug1039579-CrashReporterParent

Review of attachment 8456970 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/ipc/CrashReporterParent.cpp
@@ +120,1 @@
>              type = NS_LITERAL_CSTRING("plugin");

Do we want any additional annotation here or do we think it'll be obvious from the other context in the crash report?

@@ +152,5 @@
> +        }
> +    private:
> +        CrashReporterParent* mCR;
> +    };
> +    SyncRunnable::DispatchToThread(mainThread, new NotifyOnMainThread(this));

Is this just an expensive no-op if this is already being called on the main thread? (Shouldn't matter, this isn't perf-sensitive code.)

Comment 3

[Benjamin Smedberg]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3f55623a89

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea3f55623a89