1039593 - Clean up the TILING_LOG macros

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Botond Ballo [:botond] [away until Jun 24]]

The TILING_LOG_OBJ macro [1] is one of the more unsavoury uses of macros in Gecko, in that it declares a "magic variable" named 'tmpstr' which it expects callers to use in a specific way.

I think we can do better.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/TiledLayerBuffer.h#34

Comment 1

[Botond Ballo [:botond] [away until Jun 24]]

Attachment: bug1039593.patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8456984 [details] [diff] [review]
bug1039593.patch

Review of attachment 8456984 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! I'd even be happy if you moved Stringify into LayersLogging.h so that it's available to code all around gfx.

Comment 3

[Botond Ballo [:botond] [away until Jun 24]]

Attachment: bug1039593.patch

Updated patch to move Stringify to LayersLogging.h. Carrying r+.

Comment 4

[Botond Ballo [:botond] [away until Jun 24]]

Build-only Try push: https://tbpl.mozilla.org/?tree=Try&rev=8fe885e238d4

Comment 5

[Botond Ballo [:botond] [away until Jun 24]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b12aa2451a2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b12aa2451a2