Closed Bug 1039593 Opened 5 years ago Closed 5 years ago

Clean up the TILING_LOG macros

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: botond, Assigned: botond)

Details

Attachments

(1 file, 1 obsolete file)

The TILING_LOG_OBJ macro [1] is one of the more unsavoury uses of macros in Gecko, in that it declares a "magic variable" named 'tmpstr' which it expects callers to use in a specific way.

I think we can do better.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/TiledLayerBuffer.h#34
Attached patch bug1039593.patch (obsolete) — Splinter Review
Attachment #8456984 - Flags: review?(bugmail.mozilla)
Comment on attachment 8456984 [details] [diff] [review]
bug1039593.patch

Review of attachment 8456984 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks! I'd even be happy if you moved Stringify into LayersLogging.h so that it's available to code all around gfx.
Attachment #8456984 - Flags: review?(bugmail.mozilla) → review+
Attached patch bug1039593.patchSplinter Review
Updated patch to move Stringify to LayersLogging.h. Carrying r+.
Attachment #8456984 - Attachment is obsolete: true
Attachment #8457002 - Flags: review+
Build-only Try push: https://tbpl.mozilla.org/?tree=Try&rev=8fe885e238d4
https://hg.mozilla.org/mozilla-central/rev/1b12aa2451a2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.