1039629 - [B2G] [Camera] Placeholder warning text is shown when Camera is launched with low battery

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of placeholder low battery text

Description:
If the user launches the Camera while having a low battery, the user will see placeholder text for the low battery warning.

Repro Steps:
1) Update a Flame to 20140715000201
2) While under low battery (less than 15%) launch the Camera app.
3) Observe the warning text that appears just below a low battery icon.

Actual:
Placeholder text is shown (eg battery-low-text).

Expected:
Low battery warning text is shown (eg 10% battery remaining).

Environmental Variables:
Device: Flame 2.0 (273 MB)
Build ID: 20140715000201
Gaia: 2c6c413ed729d465c52d6c2d5d458e2eee79e956
Gecko: d32649a24965
Platform Version: 32.0a2
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Repro frequency: 100%
See attached screenshot
Unable to get logcat logs due to the fact that the message does not show up if the devce is plugged in.
The placeholder text only shows up if the user launches camera with low battery.  If the device is plugged in but the plug is disconnected while the battery is still low, the proper warning text will be displayed.

Comment 1

[Chris Kreinbring [:CKreinbring]]

The bug repros on Flame 2.1, Buri 2.1 and Buri 2.0.  The bug also repros on the 512 MB version of Flame 2.0.

Flame 2.1 (273 MB)
Build ID: 20140715040206
Gaia: 46cd188fdda2397d2b8f3303a184dcd52952e2b2
Gecko: e032c429908b
Platform Version: 33.0a1
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Flame 2.0 (512 MB)
Build ID: 20140715000201
Gaia: 2c6c413ed729d465c52d6c2d5d458e2eee79e956
Gecko: d32649a24965
Platform Version: 32.0a2
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Buri 2.1
Build ID: 20140715040206
Gaia: 46cd188fdda2397d2b8f3303a184dcd52952e2b2
Gecko: e032c429908b
Platform Version: 33.0a1
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Buri 2.0
Build ID: 20140715000201
Gaia: 2c6c413ed729d465c52d6c2d5d458e2eee79e956
Gecko: d32649a24965
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Actual result:  Launching the Camera app while battery charge is low shows placeholder warning text.

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 1.4 and Buri 1.4

Flame 1.4 (273 MB)
Build ID: 20140715000202
Gaia: b7d36622c7df92c976c37520ccab25199c7ada91
Gecko: de7ecfb00955
Platform Version: 30.0
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Buri 1.4
Build ID: 20140715000202
Gaia: b7d36622c7df92c976c37520ccab25199c7ada91
Gecko: de7ecfb00955
Version: 30.0 (1.4)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Actual result:  Launching the Camera app while battery charge is low shows a proper low battery warning.

Comment 2

[Wilson Page [:wilsonpage]]

This looks like we're showing an overlay with an l10n.js dependency before l10n is ready. Before showing it we should check `app.localized()` and if false, wait for the app to be localized before showing the overlay.

`app.once('localized', ...);`

We've taken this approach elsewhere in the app. I think it's important that we remain lazy-loading l10n.js as it's pretty costly.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Please add the regression keyword here since this issue does not happen on the 1.4 Flame(273mb).

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression from 1.4 and is not ideal but seems minor. Still should be fixed for 2.0 release but I don't consider it a blocker.

Comment 5

[Diego Marcos [:dmarcos]]

Localization is done asynchronously. The battery notifications have to wait for the app to be localized. Attached PR to address the issue

Comment 6

[Diego Marcos [:dmarcos]]

Attachment: pull Request

Comment 7

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8462905 [details] [review]
pull Request

LGTM -- Ship it!

Comment 8

[Diego Marcos [:dmarcos]]

Landed on master: 

https://github.com/mozilla-b2g/gaia/commit/f708ba15ad903d487f0b0feea2a36aeb899ff6ad

Comment 10

[Friedel Wolff]

It seems this wasn't backported to earlier branches, or is that tracked somewhere else? I just saw this with Gaia 2.0 of a few days ago.

Comment 11

[Julien Wajsberg [:julienw]]

Yep, it landed in v2.1 and was not uplifted.

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1, 2.2, and Master.

Result: The low battery warning text is shown properly("15% battery remaining").

Device: Flame 2.1 (319mb, full flash)
Build ID: 20150123001230
Gaia: 234ec27050481f4787f1f4750ec26f62ce5cc2c0
Gecko: 4cdcc0e85fc0
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
 
Device: Flame 2.2 (319mb, full flash)
Build ID: 20150123002505
Gaia: 237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko: be24dd482a83
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame Master (319mb, full flash)
BuildID: 20150123010227
Gaia: cba2f0bf49b882e0044c3cc583de8fcf83d2ffa4
Gecko: 494632b9afed
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0 Master)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0