1039638 - Move template overrides into external files

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[Gavin Suntop [:gvn]]

Right now jshint is throwing a lot of errors, mostly due to the inline templates here: 

https://github.com/mozilla/webmaker-events-2/blob/master/app/js/directives.js#L315

If possible, please make these templates external so that we can get `grunt jshint` passing again. Also, if you can fixup any other jshint errors that would be fantastic! Thanks!

Comment 1

[Gavin Suntop [:gvn]]

Also, since that code isn't part of the directives module it shouldn't go in directives.js.

Comment 2

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/144

Comment 3

[Gavin Suntop [:gvn]]

Comment on attachment 8457415 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/144

Excellent! Although Travis will still fail if that's our end goal (and it should be!).

You'll need to run `grunt clean` so the JS is beautified and fixup a couple more jshint errors (`grunt jshint`).

Once `grunt validate` passes we're all good!

Comment 4

[Gavin Suntop [:gvn]]

End goal being: Travis passing. ;)

Comment 5

[Gavin Suntop [:gvn]]

Also, FWIW we can just remove those 2 alerts. They are basically worthless because they're being sent objects.

Comment 6

[Gavin Suntop [:gvn]]

EG:

[L130:C11] W117: 'alert' is not defined.
          alert(error);
[L152:C11] W117: 'alert' is not defined.
          alert(error);

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker-events-2

https://github.com/mozilla/webmaker-events-2/commit/3d68445c7941f6bd0365588b948933f1e16204d3
Fix bug 1039638 - Move template overrides into external files