103964 - Memory leak of 1416 bytes from 1 block allocated in orkinHeap::Alloc

Status: VERIFIED FIXED

(MailNews Core :: Database, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

IMAP - I'll attach a test message that shows this leak on Windows 2000, with 
the current trunk.

The message has 7 jpg attachments...

[W] MLK: Memory leak of 1416 bytes from 1 block allocated in orkinHeap::Alloc
(nsIMdbEnv *,UINT,void * *)
    Distribution of leaked blocks
    Allocation location
    new(UINT)+0xc        [C:\WINNT\SYSTEM32\msvcrt.DLL ip=0x580039cb]
    orkinHeap::Alloc(nsIMdbEnv *,UINT,void * *)+0x24 
[c:\moz_src\mozilla\db\mork\src\orkinHeap.cpp:91 ip=0x094264bf]
    
      MORK_USED_1(mev);
      mdb_err outErr = 0;
 =>   void* block = ::operator new(inSize);
      if ( !block )
        outErr = morkEnv_kOutOfMemoryError;
    #ifdef MORK_DEBUG_HEAP_STATS
    orkinFactory::OpenFileStore(nsIMdbEnv *,nsIMdbHeap *,nsIMdbFile 
*,mdbOpenPolicy const*,nsIMdbThumb * *)+0xf7 
[c:\moz_src\mozilla\db\mork\src\orkinFactory.cpp:700 ip=0x09422ac8]
        {
          morkFactory* factory = (morkFactory*) this->mHandle_Object;
          morkStore* store = new(*ioHeap, ev)
 =>         morkStore(ev, morkUsage::kHeap, ioHeap, factory, ioHeap);
    
          if ( store )
          {
    nsMsgDatabase::OpenMDB(char const*,int)+0x31b 
[c:\moz_src\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp:919 ip=0x094eba00]
                                inOpenPolicy.mOpenPolicy_MaxLazy = 0;
    
                                ret = myMDBFactory->OpenFileStore(m_mdbEnv, 
dbHeap,
 =>                                 oldFile, &inOpenPolicy, &thumb);
                            }
                            else
                                ret = NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE;
    nsImapMailDatabase::Open(nsIFileSpec *,int,int,nsIMsgDatabase * *)+0x3f8 
[c:\moz_src\mozilla\mailnews\db\msgdb\src\nsImapMailDatabase.cpp:119 
ip=0x094e860d]
    
        nsresult err = NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE;
    
 =>     err = mailDB->OpenMDB((const char *) summarySpec, create);
    
        if (err == NS_OK)
        {
    nsMsgDatabase::OpenFolderDB(nsIMsgFolder *,int,int,nsIMsgDatabase * *)+0xe7 
[c:\moz_src\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp:859 ip=0x094eb6a7]
      nsCOMPtr <nsIFileSpec> folderPath;
      nsresult rv = folder->GetPath(getter_AddRefs(folderPath));
          NS_ENSURE_SUCCESS(rv, rv);
     =>   return Open(folderPath, create, upgrading, pMessageDB);
        }
        
        NS_IMETHODIMP nsMsgDatabase::Open(nsIFileSpec *folderName, PRBool 
create, PRBool upgrading, nsIMsgDatabase** pMessageDB)
    nsImapMailFolder::GetDatabase(nsIMsgWindow *)+0x207 
[c:\moz_src\mozilla\mailnews\imap\src\nsImapMailFolder.cpp:573 ip=0x09373177]
        
            rv = nsComponentManager::CreateInstance(kCImapDB, nsnull, NS_GET_IID
(nsIMsgDatabase), (void **) getter_AddRefs(mailDBFactory));
            if (NS_SUCCEEDED(rv) && mailDBFactory)
     =>       folderOpen = mailDBFactory->OpenFolderDB(this, PR_TRUE, PR_TRUE, 
getter_AddRefs(mDatabase));
        
            if(folderOpen == NS_MSG_ERROR_FOLDER_SUMMARY_MISSING || folderOpen 
== NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE)
              folderOpen = mailDBFactory->OpenFolderDB(this, PR_TRUE, PR_TRUE, 
getter_AddRefs(mDatabase));
    nsMsgDBFolder::GetMsgDatabase(nsIMsgWindow *,nsIMsgDatabase * *)+0x3f 
[c:\moz_src\mozilla\mailnews\base\util\nsMsgDBFolder.cpp:641 ip=0x083ba291]
        NS_IMETHODIMP
        nsMsgDBFolder::GetMsgDatabase(nsIMsgWindow *aMsgWindow,
                                      nsIMsgDatabase** aMsgDatabase)
     => {
            GetDatabase(aMsgWindow);
            if (!aMsgDatabase || !mDatabase)
                return NS_ERROR_NULL_POINTER;
    XPTC_InvokeByIndex+0x75 
[c:\moz_src\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp:152 
ip=0x100d49a6]
    XPCWrappedNative::CallMethod(XPCCallContext&,CallMode::XPCWrappedNative)
+0x10a8 [c:\moz_src\mozilla\js\src\xpconnect\src\xpcwrappednative.cpp:1951 
ip=0x046f9f96]
    XPC_WN_CallMethod(JSContext *,JSObject *,UINT,long *,long *)+0x17b 
[c:\moz_src\mozilla\js\src\xpconnect\src\xpcwrappednativejsops.cpp:1266 
ip=0x04704823]
    js_Invoke+0xba4      [c:\moz_src\mozilla\js\src\jsinterp.c:809 
ip=0x04428a0f]
    js_Interpret+0xb27f  [c:\moz_src\mozilla\js\src\jsinterp.c:2732 
ip=0x04434fb3]
    js_Invoke+0xc57      [c:\moz_src\mozilla\js\src\jsinterp.c:826 
ip=0x04428ac2]
    js_InternalInvoke+0x1a8 [c:\moz_src\mozilla\js\src\jsinterp.c:901 
ip=0x0442926e]
    JS_CallFunctionValue+0x42 [c:\moz_src\mozilla\js\src\jsapi.c:3387 
ip=0x043ec14f]
    nsJSContext::CallEventHandler(void *,void *,UINT,void *,int *,int)+0x2ad 
[c:\moz_src\mozilla\dom\src\base\nsJSEnvironment.cpp:977 ip=0x05bdb27e]
    nsJSEventListener::HandleEvent(nsIDOMEvent *)+0x64e 
[c:\moz_src\mozilla\dom\src\events\nsJSEventListener.cpp:155 ip=0x05c2815f]
    nsEventListenerManager::HandleEventSubType(nsListenerStruct *,nsIDOMEvent 
*,nsIDOMEventTarget *,UINT,UINT)+0x870 
[c:\moz_src\mozilla\content\events\src\nsEventListenerManager.cpp:1213 
ip=0x0570cfa7]
    nsEventListenerManager::HandleEvent(nsIPresContext *,nsEvent *,nsIDOMEvent 
* *,nsIDOMEventTarget *,UINT,nsEventStatus *)+0x282d 
[c:\moz_src\mozilla\content\events\src\nsEventListenerManager.cpp:1814 
ip=0x0570f8f8]

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Message with 7 jpgs

Comment 2

[David :Bienvenu]

I see a similar leak when I load this message under purify. One thing I noticed
is that the images don't display when running under Purify - do you see that as
well, Stephen?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

David, with a current trunk pulled @2pm today, I see the jpg inline correctly.

Comment 4

[David :Bienvenu]

plussing.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

I no longer see this.

Fixed.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

verified.