DCE folded MBoundsCheck instructions

RESOLVED FIXED in mozilla33

Status

()

Core
JavaScript Engine: JIT
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sunfish, Assigned: sunfish)

Tracking

unspecified
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8457061 [details] [diff] [review]
dce-boundscheck.patch

With bug 1031607, MBoundsCheck instructions can be folded away, exposing subsequent constant folding. However, the unused MBoundsCheck instructions are currently left in place because they have the isGuard() flag set. Attached is a patch which clears the isGuard flag from MBoundsCheck instructions when they are folded, which allows GVN to delete them.
Attachment #8457061 - Flags: review?(jdemooij)
Comment on attachment 8457061 [details] [diff] [review]
dce-boundscheck.patch

Review of attachment 8457061 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8457061 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/f199144be062
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Depends on: 1041746
You need to log in before you can comment on or make changes to this bug.