login error on commbadge shouldn't leave an empty review history

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: eviljeff, Assigned: kngo)

Tracking

Avenir
x86_64
Windows 7
Points:
---

Details

(Reporter)

Description

4 years ago
if, for whatever reason, login fails with the commbadge API then review history on the reviewer review pages shouldn't just be empty, as it looks like it hasn't been reviewed.  

At a minimum there should be an error shown so the reviewer knows something is up and action should be taken, ideally a (re-)login should be forced.
(Assignee)

Updated

4 years ago
Assignee: nobody → kngo
(Assignee)

Comment 1

4 years ago
https://github.com/mozilla/zamboni/commit/8fbe46fbe63fbc1f4d78d2cffb734ae55595daf4

STR:

1. Go to reviewer tools review page that has review history.
2. Clear your localStorage.
3. Refresh the page.

Actual:

The review history is empty


Expected:

It'll display an error in red saying "Sorry! We had an error fetching the review history. Please try logging in again".
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.