Closed Bug 1039714 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly

Categories

(Thunderbird :: Message Compose Window, defect)

Product:
Thunderbird
Component:
Message Compose Window
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird35 fixed, thunderbird36 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 36.0
Tracking Flags:
Tracking Status
thunderbird35 --- fixed
thunderbird36 --- fixed

People

(Reporter: mkmelin, Assigned: hiro)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Wait for modal dialog surely closed
3.25 KB, patch
standard8
: review+
Details | Diff | Splinter Review
Avoid popup menu to check reminder menu state
1.71 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
First with https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=5b67c1564598
Notably before attempting to land bug 938829, bug 1024578 - which were backed out due to orange. BUT, that orange (this) was there at least on the previous checkin also.

(same applies to bug 1038647 - they may actually be the same, idk)

SUMMARY-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly
  EXCEPTION: Popup never opened! id=button-attachPopup, state=showing
    at: utils.js line 447
       TimeoutError utils.js:447 13
       waitFor utils.js:485 1
       _click_menus test-window-helpers.js:960 1
       assert_manual_reminder_state test-attachment-reminder.js:76 25
       test_attachment_reminder_appears_properly test-attachment-reminder.js:122 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestDirectory frame.js:525 7
       runTestDirectory frame.js:707 3
       Bridge.prototype._execFunction server.js:179 10
       Bridge.prototype.execFunction server.js:183 16
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3

The failure looks random, not seen on every run.
Eh, applies to bug 1039452 I meant.
Summary: EST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/composition/test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder → EST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly
Summary: EST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly → TEST-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_attachment_reminder_appears_properly
I think focus problem will be solved by this patch, so focus() for popup menu is also removed in this patch.

Try server results:
https://hg.mozilla.org/try-comm-central/rev/e432fba32c49
Assignee: nobody → hiikezoe
Attachment #8487534 - Flags: review?(standard8)
Removing my hacks:) It would be great if this worked universally (also for the tests for which I had to add those hacks). Thanks for looking into it.
Attachment #8487534 - Flags: review?(standard8) → review+
Keywords: checkin-needed
Removing checkin-needed from keywords entry.


attachment 8487534 [details] [diff] [review] seems now to be broken.
See https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=cf3d72d3212a

I am guessing https://hg.mozilla.org/comm-central/rev/f1e58fccab14 caused conflict.
Keywords: checkin-needed
My guess was wrong.
attachment 8487534 [details] [diff] [review] makes this failure more green.
For comparison https://tbpl.mozilla.org/?tree=Thunderbird-Trunk&rev=55427f943059
The aim of assert_manual_reminder_state() is just to check the reminder menu state in menu. It can be achieved without popping up menu because the state must be changed if the checked attribute of "cmd_remindLater" is changed.

So we should just check that
1) the menu has surely command attribute which is linked to "cmd_remindLater".
2) the checked attribute of "cmd_remindLater" is an expected value.
Attachment #8521130 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8521130 [details] [diff] [review]
Avoid popup menu to check reminder menu state

Review of attachment 8521130 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! r=mkmelin
Attachment #8521130 - Flags: review?(mkmelin+mozilla) → review+
Please check in both attachments.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/da638844b965
https://hg.mozilla.org/comm-central/rev/22bd0104a157

-> FIXED
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 36.0
Yeah, if we assume that propagating the state from command to the menuitem is working correctly :) And assuming there is no code attached to the onpopupopen event on that menuitem, that would manipulate the menuitem additionally to the command itself. But yes, if there would be such code, the test will break and the author will need to explore that.
So now I get failures on my local setup here:
SUMMARY-UNEXPECTED-FAIL | test-attachment-reminder.js | test-attachment-reminder.js::test_manual_attachment_reminder
  EXCEPTION: Popup never opened! id=button-attachPopup, state=showing
    at: utils.js line 447
       TimeoutError utils.js:447 13
       waitFor utils.js:485 1
       _click_menus test-window-helpers.js:961 1
       click_manual_reminder test-attachment-reminder.js:281 1
       test_manual_attachment_reminder test-attachment-reminder.js:342 3
       Runner.prototype.wrapper frame.js:585 9
       Runner.prototype._runTestModule frame.js:655 9
       Runner.prototype.runTestModule frame.js:701 3
       Runner.prototype.runTestFile frame.js:534 3
       runTestFile frame.js:713 3
       Bridge.prototype._execFunction server.js:179 10
       Bridge.prototype.execFunction server.js:183 16
       Session.prototype.receive server.js:283 3
       AsyncRead.prototype.onDataAvailable server.js:88 3

So the popup problems are still there, the patch just works around them for some commands where possible.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: