Closed
Bug 1039798
Opened 10 years ago
Closed 10 years ago
perma-orange: test-message-header.js::test_address_book_switch_disabled_on_contact_in_mailing_list
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird33 fixed, thunderbird34 fixed)
RESOLVED
FIXED
Thunderbird 34.0
People
(Reporter: rkent, Assigned: standard8)
References
(Depends on 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
809 bytes,
patch
|
mkmelin
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
TEST-START | C:\slave\test\build\mozmill\message-header\test-message-header.js | test_address_book_switch_disabled_on_contact_in_mailing_list Step Pass: {"function": "controller.click()"} Step Pass: {"function": "controller.click()"} Test Failure: a != b: 'showing' != 'open'. TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_address_book_switch_disabled_on_contact_in_mailing_list I ran an hg bisect, the offending m-c revision is: changeset: 193930:f32dd267971e user: Neil Deakin <neil@mozilla.com> date: Mon Jul 14 13:39:04 2014 -0400 summary: Bug 1026310, set the open state only once the opening transition is finished, rename the internal popup states to be clearer, fix UITour.jsm to che ck the showing state, r=MattN,neil These errors were previously being flagged, IMHO incorrectly, here: https://bugzilla.mozilla.org/show_bug.cgi?id=964025
Reporter | ||
Updated•10 years ago
|
Blocks: 1026310
Keywords: intermittent-failure
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 42•10 years ago
|
||
This is what was done in bug 994117 attachment 8428682 [details] [diff] [review]. It drops the animation from the contact panel, so we get very similar behavior to before. This is probably a more stable and easier option to dealing with the panel opening in async fashion and waiting for it to be fully open etc. It works fine for me locally.
Reporter | ||
Comment 43•10 years ago
|
||
Comment on attachment 8467674 [details] [diff] [review] Turn off animations on contact panel Sorry Mark but I don't do mozmill at all. I only got involved with this to help find the regression, but I don't feel competent to do any reviews. So passing.
Attachment #8467674 -
Flags: review?(kent)
Comment 44•10 years ago
|
||
Comment on attachment 8467674 [details] [diff] [review] Turn off animations on contact panel Review of attachment 8467674 [details] [diff] [review]: ----------------------------------------------------------------- Of course it covers up the underlying core bug, but it's not like it will get fixed here anyway. So, looks ok to me, r=mkmelin ::: mail/test/mozmill/message-header/test-message-header.js @@ +73,5 @@ > + > + // Disable animations on the panel, so that we don't have to deal with > + // async openings. > + let contactPanel = mc.eid('editContactPanel').getNode(); > + contactPanel.setAttribute("animate", false); You might want to remove the attribute in teardown too.
Attachment #8467674 -
Flags: review+
Assignee | ||
Comment 45•10 years ago
|
||
Comment on attachment 8467674 [details] [diff] [review] Turn off animations on contact panel [Triage Comment] Going to take this straight onto aurora to fix bustage there as well.
Attachment #8467674 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 46•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f734b640be11 https://hg.mozilla.org/releases/comm-aurora/rev/a29fe6eaf4e2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-thunderbird33:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
Assignee | ||
Updated•10 years ago
|
status-thunderbird34:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•