[B2G][FTE] FTU WiFi setup screen's password text box has no max limit

RESOLVED FIXED in 2.1 S1 (1aug)

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rmead, Assigned: mancas)

Tracking

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v1.4 affected, b2g-v2.0 affected, b2g-v2.1 verified)

Details

(Whiteboard: [273MB-Flame-Support][2.0-exploratory], URL)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 8457603 [details]
Password_Size_Limit.txt

Description:
When entering a password at the FTU WiFi setup screen, there is no text limit dictating the size of your password. If you go to WiFi through the Settings page and try to enter in a password, the text is limited to 63 characters.

Prerequisite: Factory reset or flash phone.

Repro Steps:
1) Update a Flame to Build ID: 20140716000201
2) During FTU, hit next until you get to WiFi setup screen.
3) Select a network that requires a password.
4) Enter 64 characters into password text box.

Actual:
You can keep typing as many characters as you want into the password text box.

Expected:
You should not be able to have more then 63 characters in the password text box.

Flame 2.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20140716000201
Gaia: 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6
Gecko: 913827496f65
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Keywords: Password, limit, characters, WiFi

Repro frequency: (100%)
See attached: Logcat, Video - http://youtu.be/7EpUOhFzT_Q
(Reporter)

Comment 1

5 years ago
This issue DOES occur on Flame 2.1 (273mb), Buri 2.1, Flame 2.0(512mb), Buri 2.0, Flame 1.4 (273mb), Buri 1.4, Buri 1.3

No limit to string length in FTU WiFi password text box.

Flame 2.1 (273mb)

Environmental Variables:
Device: Flame Master
Build ID: 20140716040207
Gaia: d29773d2a011825fd77d1c0915a96eb0911417b6
Gecko: 691ffea49efb
Version: 33.0a1 (Master)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140716040207
Gaia: d29773d2a011825fd77d1c0915a96eb0911417b6
Gecko: 691ffea49efb
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Flame 2.0 (512mb)

Environmental Variables:
Device: Flame 2.0
BuildID: 20140716000201
Gaia: 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6
Gecko: 913827496f65
Version: 32.0a2 (2.0)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Buri 2.0

Environmental Variables:
Device: Buri 2.0
Build ID: 20140716000201
Gaia: 5f8b1b8a2da9e3b531eee817a669f57fa4d9b9c6
Gecko: 913827496f65
Version: 32.0a2 (2.0)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Flame 1.4 (273mb)

Environmental Variables:
Device: Flame 1.4
Build ID: 20140716000202
Gaia: 393d72937727ad20e82b2ff7b13e3d7ff077a9f0
Gecko: 932c37978d37
Version: 30.0 (1.4)
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


Buri 1.4

v1.4 Environmental Variables:
Device: Buri v1.4 MOZ ril
BuildID: 20140716000202
Gaia: 393d72937727ad20e82b2ff7b13e3d7ff077a9f0
Gecko: 932c37978d37
Version: 30.0
Firmware Version: v1.2-device.cfg


Buri 1.3

Environmental Variables:
Device: Buri 1.3
Build ID: 20140716024003
Gaia: 23f55be856cef53c6604a6fe4aeb09061afbc897
Gecko: b9087513a198
Version: 28.0 (1.3)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
(Reporter)

Comment 2

5 years ago
Environmental variables from comment 0 are from testing on Flame 2.0 (273mb)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
(Assignee)

Updated

5 years ago
Assignee: nobody → b.mcb
(Assignee)

Comment 3

5 years ago
Created attachment 8462480 [details] [review]
maxLength attribute
Attachment #8462480 - Flags: review?(fernando.campo)
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][lead-review+]
Comment on attachment 8462480 [details] [review]
maxLength attribute

will wait to review all when the tests are added, but so far code is good and work on device.
Attachment #8462480 - Flags: review?(fernando.campo)
(Assignee)

Updated

4 years ago
Attachment #8462480 - Flags: review?(fernando.campo)
Comment on attachment 8462480 [details] [review]
maxLength attribute

Thanks for adding the test!
Merge when green
Attachment #8462480 - Flags: review?(fernando.campo) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/ac6f9af8aa22abc655a389b6cb15b4a7a383388b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)

Comment 7

4 years ago
This issue has been verified successfully on Flame 2.1

See attachment: Verify_video.3gp
Reproducing rate: 0/5
Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
status-b2g-v2.1: fixed → verified

Comment 8

4 years ago
Created attachment 8531439 [details]
Verify_video.3gp
You need to log in before you can comment on or make changes to this bug.