Closed Bug 1039917 Opened 5 years ago Closed 5 years ago

Fix clang and gcc warnings in webrtc/signaling

Categories

(Core :: WebRTC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This patch fixes the following warnings reported by OS X clang and Android gcc. Most are warnings about size_t sprintf parameters or C functions not declaring local variables at the top of the function.

media/webrtc/signaling/src/common/browser_logging/WebRtcLog.cpp:20:20 [-Wunused-variable] 'default_log' defined but not used
media/webrtc/signaling/src/sipcc/core/sdp/ccsdp.c:12:5 [enabled by default] return makes integer from pointer without a cast
media/webrtc/signaling/src/sipcc/core/sdp/sdp_utils.c:92:31 [-Wsign-compare] comparison between signed and unsigned integer expressions

media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_core.c:9157:17 [-Wformat=] format '%lu' expects argument of type 'long unsigned int', but argument 9 has type 'size_t'
media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_pmh.c:4715:9 [-Wformat=] format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'size_t'
media/webrtc/signaling/src/sipcc/core/sipstack/ccsip_subsmanager.c:2676:13 [-Wformat=] format '%lu' expects argument of type 'long unsigned int', but argument 9 has type 'size_
media/webrtc/signaling/src/softphonewrapper/CC_SIPCCService.cpp:563:207 [-Wformat=] format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'std::vec

media/webrtc/signaling/src/sipcc/cpr/common/cpr_ipc.c:285:5 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/common/cpr_ipc.c:447:5 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
media/webrtc/signaling/src/sipcc/cpr/common/cpr_ipc.c:595:5 [-Wdeclaration-after-statement] ISO C90 forbids mixed declarations and code
Attachment #8457775 - Flags: review?(rjesup)
Attachment #8457775 - Flags: review?(rjesup) → review+
https://hg.mozilla.org/mozilla-central/rev/f3cee88147f2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.