If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[tarako][dolphin] There is no "Call waiting" text on "Call Settings" page after turning on FDN function.

RESOLVED FIXED in Firefox OS v1.4

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Wei Gao (Spreadtrum), Assigned: Wei Gao (Spreadtrum))

Tracking

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)
Bug Flags:
in-moztrap +

Firefox Tracking Flags

(blocking-b2g:1.4+, b2g-v1.3T affected, b2g-v1.4 fixed, b2g-v2.0 verified, b2g-v2.1 verified)

Details

(URL)

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
OS version
---------------------------------------------
FireFoxOS v1.3t v1.4

Reproduce steps:
---------------------------------------------
Settings app > Call Settings >
Turn on FDN function, return to "Call Settings" page.

Expected result:
---------------------------------------------
There still should have "Call waiting" text on orignal "Call waiting" label.

Actual result:
---------------------------------------------
There is a "yellow exclamation mark" on original "Call waiting" label and there is no "Call waiting" text on it.

Probability:
---------------------------------------------
Always Recurrence
(Assignee)

Comment 1

3 years ago
Created attachment 8457827 [details] [diff] [review]
add_call_waiting_label_when_FDN.patch

Dear Evelyn

I think there is a interface issue.
I have added a patch, could you help to transmit this bug to the right owner?
Thanks a great.
Flags: needinfo?(ehung)
Comment on attachment 8457827 [details] [diff] [review]
add_call_waiting_label_when_FDN.patch

Arthur, would you mind to take a look? Thanks!
Attachment #8457827 - Flags: review?(arthur.chen)
Flags: needinfo?(ehung)
Comment on attachment 8457827 [details] [diff] [review]
add_call_waiting_label_when_FDN.patch

The bug results from the change of the dom structure of check boxes. We should modify the css selector to make it only hide the span of the check box instead of the entire label. I would suggest to modify the following selector from

#menuItem-callWaiting[data-state="unknown"] .checkbox-label

to

#menuItem-callWaiting[data-state="unknown"] .checkbox-label input ~ span:after
Attachment #8457827 - Flags: review?(arthur.chen)
(Assignee)

Comment 4

3 years ago
Created attachment 8459526 [details] [diff] [review]
make_only_check_box_hide.patch

(In reply to Arthur Chen [:arthurcc] from comment #3)
> Comment on attachment 8457827 [details] [diff] [review]
> add_call_waiting_label_when_FDN.patch
> 
> The bug results from the change of the dom structure of check boxes. We
> should modify the css selector to make it only hide the span of the check
> box instead of the entire label. I would suggest to modify the following
> selector from
> 
> #menuItem-callWaiting[data-state="unknown"] .checkbox-label
> 
> to
> 
> #menuItem-callWaiting[data-state="unknown"] .checkbox-label input ~
> span:after

That's cool. This modification suggestion is best, simple and valid.
I modified it as you say.
Could it be granted for this issue?
Thanks a great.
Attachment #8459526 - Flags: review?(arthur.chen)
(Assignee)

Updated

3 years ago
Attachment #8457827 - Attachment is obsolete: true
Comment on attachment 8459526 [details] [diff] [review]
make_only_check_box_hide.patch

r=me, thanks! Could you create a pull request on github based on the patch?
Attachment #8459526 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 6

3 years ago
Created attachment 8459984 [details] [review]
[master] pull request

Dear Arthur

This is a PR for master.
I think it also suit v1.3t and v1.4. Do I need to recommit a v1.3t and v1.4 PR again?
Please help to review.
Thanks a great.
Attachment #8459984 - Flags: review?(arthur.chen)
(Assignee)

Updated

3 years ago
blocking-b2g: --- → 1.4?
status-b2g-v1.3T: --- → affected
status-b2g-v1.4: --- → affected
Comment on attachment 8459984 [details] [review]
[master] pull request

As this should be cherry-picked easily, we don't need to create PR against each branch.
Attachment #8459984 - Flags: review?(arthur.chen) → review+
Wayne, can we still uplift patches to v1.3t?
Flags: needinfo?(wchang)

Comment 9

3 years ago
Let's also land this on v1.4.
blocking-b2g: 1.4? → 1.4+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/1cc333b33d224362e41fc897e0818dee05adb824
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S1 (1aug)
v2.0: https://github.com/mozilla-b2g/gaia/commit/3646632e8e594a3ced3623d44317e15a29c5e42e
v1.4: https://github.com/mozilla-b2g/gaia/commit/be07a9af1dc0c9a14136880b322094c70a2dcae2
Assignee: nobody → wei.gao
status-b2g-v1.4: affected → fixed
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Wei,

Given the critical stage of 1.3t, I am reluctant to land patches other than those we're focusing on for launch. I don't see this one necessary at the moment so let's just have it on 1.4 onward releases.

Thanks
Flags: needinfo?(wchang)
Flags: in-moztrap?(ychung)
New test case needs to be added. There is no existing test case.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14370/
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Flags: in-moztrap?(ychung)
Flags: in-moztrap+

Comment 15

3 years ago
Created attachment 8531141 [details]
Verify_image_Flame_2.0.png

This issue has been verified successfully on Flame 2.0,2.1

See attachment: Verify_image_Flame_2.0.png and Verify_image_Flame_2.1.png
Reproducing rate: 0/5
flame 2.0 version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
FLame2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0

Comment 16

3 years ago
Created attachment 8531142 [details]
Verify_image_Flame_2.1.png

Updated

3 years ago
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.