1039983 - [Calendar] Display event at the proper time slot for week/day view after add or edit event

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Harly Hsu[:harly]]

Description:
In week or day view, when user add or edit an event, and then change the date/time and press save, it should go back to the previous enter view with the event displayed at the set time slot.

Repro Steps:
1) Go to day view
2) Tap add event
3) Change event date & time 
4) Tap save

Actual:
Event displayed in day view at the set date, but will still stay at the previous time slot

Expected:
Calendar will scroll down and display the added event at the proper time slot

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] millermedeiros:1039983-scroll-to-event to mozilla-b2g:master

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8551515 [details] [review]
[PullReq] millermedeiros:1039983-scroll-to-event to mozilla-b2g:master

LGTM! And I think autolander is going to magic this for us?

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/00b87f61b666bf25c9f5bdd3c79c40cd1619a07e

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8551515 [details] [review]
[PullReq] millermedeiros:1039983-scroll-to-event to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: week/day views won't scroll to last edited/created event, it might look like event wasn't saved properly
[Testing completed]: manual + marionette
[Risk to taking this patch] (and alternatives if risky): low risk
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b741e5ea4db93f2bc3263b248529c6ae6a2dfde1

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v2.2&3.0 by the STR in Comment 0.

Actual results: Calendar will scroll down and display the added event at the proper time slot in Week/Day view.
See attachment: verified_v2.2&3.0.3gp
Reproduce rate: 0/10


Device: Flame v2.2 build(Verified) 
Build ID               20150628002505
Gaia Revision          0179935627012dfde3ca036c9a71035be463b7ad
Gaia Date              2015-06-26 21:13:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/35e09270da3a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150628.035537
Firmware Date          Sun Jun 28 03:55:48 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Verified)
Build ID               20150629134017
Gaia Revision          27fe0f4261e3685187769411f2f74cff19287b19
Gaia Date              2015-06-29 14:29:00
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/c26dbd63604d
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150629.170951
Firmware Date          Mon Jun 29 17:10:03 EDT 2015
Bootloader             L1TC000118D0

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2&3.0.3gp