1040012 - Long press on period key in the Greek keyboard should show the special character menu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The UX spec p.23 in bug 983043 attachment 8454327 [details] mentions that the Greek keyboard should also display the addiotional menu on long press. Those characters are quite common in Greek, too.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

My guess is that we need to do something along the lines of the patch in bug 807846 here.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yes, just defining those alternative chars in layout/el.js should do the trick.
Thanks.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21925

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8458643 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21925

r=me, I think you're native in Greek, right?
So, I don't think we need to find another one to review this.

Thank you.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Yep, born and raised :-)

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Try was green.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/2b9662e2c34442495a18b0966323e0c9ebaa93fb

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8458643 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21925

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): new feature that is present on the English keyboard, but missing from the Greek keyboard
[User impact] if declined: Greek keyboard users will have to press multiple keys in order to enter some punctuation marks
[Testing completed]: locally
[Risk to taking this patch] (and alternatives if risky): tiny, configuration-only fix for the keyboard app
[String changes made]: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/df76a92ece31600b4d21255790993bda597279a8