1040016 - Allow the Windows content sandbox to be enabled via a nightly only pref.

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Bob Owen (:bobowen)]

Now that bug 985252 is about to land and the Windows sandboxing code will be compiled unconditionally, it makes sense to allow the content sandbox to be turned on via a pref.

This will make it easier for people to test the sandbox and for when we want to start running tests on tinderbox with e10s and the sandbox enabled.

I think it makes sense to only have this pref in nightly.

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

So far we've been using environment variables for enabling/disabling sandboxing at runtime. Is there a preference (no confusion intended) one way or the other for environment variables vs a nightly-only pref?

Comment 2

[Bob Owen (:bobowen)]

(In reply to Tim Abraldes [:TimAbraldes] [:tabraldes] from comment #1)
> So far we've been using environment variables for enabling/disabling
> sandboxing at runtime. Is there a preference (no confusion intended) one way
> or the other for environment variables vs a nightly-only pref?

Well, I think one of the factors here is that we want addon developers to be able to test their code with the sandbox enabled.
That was the original reason I started looking at a warn only sandbox (I'm not sure where the original request came from).
I would imagine that flipping a pref would be fairly familiar to most addon developers, but I have no solid evidence to back that up. :)

I'm happy to go with any solution that makes things straight forward and doesn't involve actually building firefox.

Comment 3

[Bob Owen (:bobowen)]

Done as part of bug 1018966.