unbusy is called too early in the timeout

RESOLVED FIXED in Firefox 33

Status

RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 33
x86_64
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8457950 [details] [diff] [review]
v1
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8457950 - Flags: review?(jryans)
Comment on attachment 8457950 [details] [diff] [review]
v1

Review of attachment 8457950 [details] [diff] [review]:
-----------------------------------------------------------------

Wait, what?  So you made a new local variable and that changes something?!
Attachment #8457950 - Flags: review?(jryans)
(Assignee)

Comment 3

4 years ago
unbusy kills the this._busyPromise reference. unbusy can't be moved after the reject because that would cause a failure (reject) instead of a timeout.
Comment on attachment 8457950 [details] [diff] [review]
v1

Review of attachment 8457950 [details] [diff] [review]:
-----------------------------------------------------------------

Ah okay, that makes a bit more sense.
Attachment #8457950 - Flags: review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/361e5c7a5ef2
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/361e5c7a5ef2
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.