Closed Bug 1040050 Opened 12 years ago Closed 6 years ago

Toolbox can't be properly destroyed during shutdown

Categories

(DevTools :: General, defect)

x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: paul, Unassigned)

Details

Attachments

(2 files)

When I close Firefox with an opened toolbox, I see exceptions in my terminal. I tried to fix them, but while Firefox shuts down, half of XBL bindings are not operational anymore. I suggest that we don't even try to destroy the toolbox at shutdown.
Attached patch v1 — — Splinter Review
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8457952 - Flags: review?(past)
Comment on attachment 8457952 [details] [diff] [review] v1 Review of attachment 8457952 [details] [diff] [review]: ----------------------------------------------------------------- This seems like a very big hammer for a small nail (I don't get any exceptions myself), but I can't think of anything bad about it. I don't believe we store prefs or anything like that on toolbox destruction. ::: browser/devtools/framework/toolbox.js @@ +1294,5 @@ > + // the destruction of the toolbox and all the panels. Too many things > + // are not operationals at this stage (mostly, XBL bindings), which > + // make any attempt of destructing the toolbox impossible. > + if (Services.startup.shuttingDown) { > + this._destroyer = Promise.resolve(); You want lowercase promise here.
Attachment #8457952 - Flags: review?(past) → review+
Since the exceptions that I've been getting are highlighter actors specific, one potential concern is that this fix would not initiate an orderly server shutdown in the remote debugging case. Can you make sure that we don't leave the server open in that case?
(In reply to Panos Astithas [:past] from comment #3) > Since the exceptions that I've been getting are highlighter actors specific Funny, because I don't get any exceptions for the highlighter. And the highlighter has no XBL afaik, so these exception are, I think, fixable. > one potential concern is that this fix would not initiate an orderly server > shutdown in the remote debugging case. Can you make sure that we don't leave > the server open in that case? Yes.
First round of exceptions I get. I can fix them, but then more of the same kind appear: console.error: Message: Error: Connection closed Stack: Front<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1040:23 exports.WalkerFront<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:2214:5 frontProto/</proto[name]/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1223:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1112:7 DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:874:9 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9 DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:861:1 LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14 console.error: Message: Error: Connection closed Stack: Front<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1040:23 exports.WalkerFront<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:2214:5 frontProto/</proto[name]/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1223:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1112:7 DebuggerClient.prototype.onPacket/<@resource://gre/modules/devtools/dbg-client.jsm:874:9 resolve@resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 then@resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9 DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:861:1 LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
Actually, these are not shutdown specific. These are: console.error: Panel inspector: Message: TypeError: this._tabbox.tabpanels is undefined Stack: ToolSidebar_destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/sidebar.js:221:5 InspectorPanel__destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:523:5 Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1268:26 EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:137:11 TabTarget.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:443:5 eventSource/aProto.notify@resource://gre/modules/devtools/dbg-client.jsm:186:9 DebuggerClient.prototype.onClosed@resource://gre/modules/devtools/dbg-client.jsm:991:5 DebuggerTransport.prototype.close@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:203:7 DebuggerTransport.prototype.onInputStreamReady<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:346:7 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14 TypeError: this.doc is undefined: Toolbox.prototype.destroyHost@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1243:5 Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1287:22 EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:137:11 TabTarget.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:443:5 eventSource/aProto.notify@resource://gre/modules/devtools/dbg-client.jsm:186:9 DebuggerClient.prototype.onClosed@resource://gre/modules/devtools/dbg-client.jsm:991:5 DebuggerTransport.prototype.close@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:203:7 DebuggerTransport.prototype.onInputStreamReady<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:346:7 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
As I do more tests, I'm less convinced it's a shutdown-only issue. It is a XBL issue, but it might happen even when a window is just closed. Maybe toolboxes should be closed sooner. This needs more investigation.
This is what I'm getting: console.error: Message: TypeError: this.docShell is null Stack: TabActor.prototype.chromeEventHandler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:551:5 exports.HighlighterActor<._getPickerListenerTarget@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/highlighter.js:218:5 exports.HighlighterActor<._stopPickerListeners@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/highlighter.js:231:18 exports.HighlighterActor<.cancelPick<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/highlighter.js:250:7 actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:943:19 DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1223:15 LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14 makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
The errors in comment 5 are connection shutdown-specific, so it's broadly about the same thing. The protocol.js error is interesting, I think it should either resolve the promises on shutdown or the callers must be changed to expect promise rejection in that case and treat it as a warning, at most.
This fixes the errors I'm getting, but seems redundant with your other patch. If you decide to take the more targeted approach it could be of help.
Assignee: paul → nobody
Status: ASSIGNED → NEW
Product: Firefox → DevTools

I don't thing this report is relevant any more, closing.

Honza

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: