Move GMPInstallManager front end code from delayed-startup+delay to final-ui-startup+delay

RESOLVED WORKSFORME

Status

()

enhancement
RESOLVED WORKSFORME
5 years ago
4 months ago

People

(Reporter: bbondy, Unassigned)

Tracking

(Blocks 4 bugs)

unspecified
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

5 years ago
Yoric suggested that a better place for this to live is final-ui-startup+delay
This is only for the 4 lines of code in browser.js currently.
Flags: firefox-backlog+
Flags: needinfo?(dteller)
Reporter

Comment 1

5 years ago
Posted patch bug1046644.diff (obsolete) — Splinter Review
Clearing needinfo, I had emailed dteller and he tipped me off on Timer.jsm which was the module I needed for the early startup timer.
Attachment #8468495 - Flags: review?(georg.fritzsche)
Flags: needinfo?(dteller)
Reporter

Comment 2

5 years ago
Posted patch Patch v1 (obsolete) — Splinter Review
Correct patch
Attachment #8468495 - Attachment is obsolete: true
Attachment #8468495 - Flags: review?(georg.fritzsche)
Attachment #8468497 - Flags: review?(georg.fritzsche)
Reporter

Comment 3

5 years ago
Posted patch Patch v1.Splinter Review
Attachment #8468497 - Attachment is obsolete: true
Attachment #8468497 - Flags: review?(georg.fritzsche)
Attachment #8468500 - Flags: review?(georg.fritzsche)
Comment on attachment 8468500 [details] [diff] [review]
Patch v1.

Review of attachment 8468500 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/nsBrowserGlue.js
@@ +521,5 @@
>  
> +    // Delay this a minute because there's no rush
> +    setTimeout(() => {
> +        this.gmpInstallManager = new GMPInstallManager();
> +        // We don't really care about the results, if somenoe is interested they

Let's fix the typo while we're at it.
Attachment #8468500 - Flags: review?(georg.fritzsche) → review+
Reporter

Updated

4 years ago
Assignee: netzen → nobody

Bug 1388145 moved this initialization to the right place.

Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.