1040080 - Fix error in nsIMessageManager.idl's docs related to child process mms

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/content/base/public/nsIMessageManager.idl#126

*  Parent process                      Child processes
* ----------------                    -----------------
*  global PPMM
*   |
*   +<----> child PPMM
*   |
*   +-->parent PMM1<------------------>child process CMM1
*   |
*   +-->parent PMM2<------------------>child process PMM2
*   ...

I think this should read:

*  Parent process                      Child processes
* ----------------                    -----------------
*  global PPMM
*   |
*   +<----> child PPMM
*   |
*   +-->parent PMM1<------------------>child PMM1
*   |
*   +-->parent PMM2<------------------>child PMM2
*   ...

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch v.1

The final text looks like:

* Message managers corresponding to process boundaries
* ====================================================
*
* The second realm of message managers is the "process message
* managers".  With one exception, these always correspond to process
* boundaries.  The picture looks like
*
*  Parent process                      Child processes
* ----------------                    -----------------
*  global (GPPMM)
*   |
*   +<----> psuedo-child PPMM  (the 'child' mm for in-process tabs)
*   |
*   +-->parent (PPMM1)<------------------>child (CPMM1)
*   |
*   +-->parent (PPMM2)<------------------>child (CPMM2)
*   ...
*
* For example: the parent-process PPMM1 sends messages to
* the child-process CPMM1.
*
* For example: CPMM1 sends messages directly to PPMM1. The global GPPMM
* will also notify their message listeners when the message arrives.
*
* For example: messages sent through the global GPPMM will be
* dispatched to the listeners of the same-process, "psuedo-child PPMM",
* and to to CPMM1, CPMM2, etc.
*
*   ***** PERFORMANCE AND SECURITY WARNING *****
* Messages broadcast through the GPPMM can result in messages
* being dispatched across many OS processes, and to many processes
* with different permissions.  Great care should be taken when
* broadcasting.

Comment 2

[Jim Mathies [:jimm]]

I removed the extra 'to' here: 

"and to CPMM1, CPMM2, etc."

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8458025 [details] [diff] [review]
patch v.1

>+ *   +<----> psuedo-child PPMM  (the 'child' mm for in-process tabs)
it would be pseudo, not psuedo, but
I think in-process-child PPMM might be better, so
|
+-->in-process-parent PMM<----> in-process-child PMM

Comment 4

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/d62df3aa085b

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d62df3aa085b