Closed
Bug 1040174
Opened 11 years ago
Closed 11 years ago
Disable the usage of SEH in gtest where we disable it for Gecko
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
934 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8458094 -
Flags: review?(mh+mozilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8458094 [details] [diff] [review]
Disable the usage of SEH in gtest where we disable it for Gecko
Review of attachment 8458094 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +502,5 @@
>
> # Disable SEH on clang-cl because it doesn't implement them yet.
> if test -z "$CLANG_CL"; then
> AC_DEFINE(HAVE_SEH_EXCEPTIONS)
> + AC_DEFINE_UNQUOTED(GTEST_HAS_SEH, 1)
I don't think you need this for MSVC, while you do need an explicit disable for clang. Don't forget every time you add an AC_DEFINE or an AC_SUBST, the result is everything is rebuilt, even if that changes nothing. So for no-ops, it's better not to add anything.
Attachment #8458094 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•