Closed Bug 1040174 Opened 9 years ago Closed 9 years ago

Disable the usage of SEH in gtest where we disable it for Gecko

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Disable the usage of SEH in gtest where we disable it for Gecko
934 bytes, patch
glandium
: review+
Details | Diff | Splinter Review 
      No description provided.
Assignee: nobody → ehsan
Blocks: winclang
Attachment #8458094 - Flags: review?(mh+mozilla)
Comment on attachment 8458094 [details] [diff] [review]
Disable the usage of SEH in gtest where we disable it for Gecko

Review of attachment 8458094 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +502,5 @@
>  
>          # Disable SEH on clang-cl because it doesn't implement them yet.
>          if test -z "$CLANG_CL"; then
>              AC_DEFINE(HAVE_SEH_EXCEPTIONS)
> +	    AC_DEFINE_UNQUOTED(GTEST_HAS_SEH, 1)

I don't think you need this for MSVC, while you do need an explicit disable for clang. Don't forget every time you add an AC_DEFINE or an AC_SUBST, the result is everything is rebuilt, even if that changes nothing. So for no-ops, it's better not to add anything.
Attachment #8458094 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/0f35b34a3f57
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.