1040250 - (theme-yosemite) [meta] Tracking: Implement visual changes for OS X Yosemite

Status: NEW

(Firefox :: General, enhancement)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Bug 1020551 has mockups for the style changes needed in order to integrate nicely with the new OS X release.
This is the corresponding breakdown bug for the implementation.

Comment 1

[José Jeria]

Should it be the other way around, that bug 1044595 blocks this one? Meta bugs are fixed by fixing the dependencies, not what it blocks.

Comment 2

[:Gijs (he/him)]

Nicking this. Marco, can you update the spreadsheet? Thanks!

Comment 3

[:Gijs (he/him)]

Michael, can you clarify something? These mockups:

http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-Customize.png
https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728

seem to be using different toolbar icons. Can you clarify what the difference there is, or if that was an oversight?

I also noticed that there seems to be a change in padding on the combined items (cut/copy/paste, zoom in/out/reset) as compared to the current state on OS X (they've gone from roughly 29 pixels between lines to 33 pixels between lines) - is that intentional and/or should that be applied everywhere rather than just on Yosemite?

Comment 4

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #3)
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png

Also, this is using color instead of pressed state for the menu button again. We previously switched back to using an actual pressed state because otherwise we have issues distinguishing between "checked" and hover/active states. Did you consider how e.g. the downloads and bookmark button states would look with this? Can you provide mockups for those, too? (I didn't find a comprehensive mockup of the different toolbar button states, I'm sorry if I missed it somewhere obvious)

Comment 5

[Marco Mucci [:MarcoM]]

Added to Iteration 34.2

Comment 6

[:Gijs (he/him)]

Posting in replies from my meeting with mmaslaney:

(In reply to :Gijs Kruitbosch from comment #3)
> Michael, can you clarify something? These mockups:
> 
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png
> https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728
> 
> seem to be using different toolbar icons. Can you clarify what the
> difference there is, or if that was an oversight?

The fade-out in customize mode wasn't an intentional part of the design, so we can leave the buttons as they are in customize mode.

> I also noticed that there seems to be a change in padding on the combined
> items (cut/copy/paste, zoom in/out/reset) as compared to the current state
> on OS X (they've gone from roughly 29 pixels between lines to 33 pixels
> between lines) - is that intentional and/or should that be applied
> everywhere rather than just on Yosemite?

This, too, wasn't an intentional change.

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> > Customize.png
> 
> Also, this is using color instead of pressed state for the menu button
> again. We previously switched back to using an actual pressed state because
> otherwise we have issues distinguishing between "checked" and hover/active
> states. Did you consider how e.g. the downloads and bookmark button states
> would look with this? Can you provide mockups for those, too? (I didn't find
> a comprehensive mockup of the different toolbar button states, I'm sorry if
> I missed it somewhere obvious)

We can leave this as-is instead of switching to the blue highlight.

Comment 7

[Benjamin Kerensa [:bkerensa]]

Are we planning on refreshing icons and the application icons to be consistent with Yosemite's new look? Not sure our current Firefox app icon would look like it belonged.

Comment 8

[:Gijs (he/him)]

(In reply to Benjamin Kerensa [:bkerensa] from comment #7)
> Are we planning on refreshing icons and the application icons to be
> consistent with Yosemite's new look? Not sure our current Firefox app icon
> would look like it belonged.

The in-app icons are tracked in bug 1050809. I don't think we're planning to update the app icon. I've not user Yosemite toooo much, but I don't think we "stick out" much, so I personally wouldn't feel that it's necessary to change there.

Comment 9

[Dirkjan Ochtman (:djc)]

Agree that the app icons certainly shouldn't be a priority here. Actually I think the Nightly icon fits in nicely with the new round icon trend, even if the lighting is a little bit different from the HIG.

Comment 10

[Lawrence Mandel [:lmandel] (use needinfo)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Support for new version of OSX
[Suggested wording]: OS X 10.10 Yosemite support
[Links (documentation, blog post, etc)]:

I would like to note this in Firefox 34 as we have made a good number of improvements in this release and this is the first release that will ship after Yosemite's release.