Open Bug 1040250 (theme-yosemite) Opened 9 years ago Updated 2 months ago

[meta] Tracking: Implement visual changes for OS X Yosemite

Categories

(Firefox :: General, enhancement)

33 Branch
x86
macOS
enhancement

Tracking

()

Tracking Status
relnote-firefox --- 34+

People

(Reporter: phlsa, Unassigned)

References

(Depends on 10 open bugs)

Details

(Keywords: meta, Whiteboard: [yosemite])

Bug 1020551 has mockups for the style changes needed in order to integrate nicely with the new OS X release.
This is the corresponding breakdown bug for the implementation.
Flags: firefox-backlog+
QA Whiteboard: [qa-]
Blocks: 1044595
Should it be the other way around, that bug 1044595 blocks this one? Meta bugs are fixed by fixing the dependencies, not what it blocks.
No longer blocks: 1044595
Depends on: 1044595
Keywords: meta
Summary: Breakdown: Implement visual changes for OS X Yosemite → [10.10] Breakdown: Implement visual changes for OS X Yosemite
Depends on: 1044601, 1042338, 1042331
Whiteboard: [yosemite]
Depends on: 1044258
Depends on: 1045201
Depends on: 1045206
Depends on: 1045213
Depends on: 1045217
Depends on: 1019587
Depends on: 1047828
Points: --- → 5
Depends on: 1050804
Depends on: 1050807
Nicking this. Marco, can you update the spreadsheet? Thanks!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 34.2
Flags: needinfo?(mmucci)
Depends on: 1050809
Michael, can you clarify something? These mockups:

http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-Customize.png
https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728

seem to be using different toolbar icons. Can you clarify what the difference there is, or if that was an oversight?

I also noticed that there seems to be a change in padding on the combined items (cut/copy/paste, zoom in/out/reset) as compared to the current state on OS X (they've gone from roughly 29 pixels between lines to 33 pixels between lines) - is that intentional and/or should that be applied everywhere rather than just on Yosemite?
Flags: needinfo?(mmaslaney)
(In reply to :Gijs Kruitbosch from comment #3)
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png

Also, this is using color instead of pressed state for the menu button again. We previously switched back to using an actual pressed state because otherwise we have issues distinguishing between "checked" and hover/active states. Did you consider how e.g. the downloads and bookmark button states would look with this? Can you provide mockups for those, too? (I didn't find a comprehensive mockup of the different toolbar button states, I'm sorry if I missed it somewhere obvious)
Depends on: 1050816
Added to Iteration 34.2
Flags: needinfo?(mmucci)
Depends on: 1051522
Depends on: 1052466
Depends on: 1052522
Depends on: 1052527
Depends on: 1052534
No longer depends on: 1044258
Depends on: 1053073
Posting in replies from my meeting with mmaslaney:

(In reply to :Gijs Kruitbosch from comment #3)
> Michael, can you clarify something? These mockups:
> 
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png
> https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728
> 
> seem to be using different toolbar icons. Can you clarify what the
> difference there is, or if that was an oversight?

The fade-out in customize mode wasn't an intentional part of the design, so we can leave the buttons as they are in customize mode.

> I also noticed that there seems to be a change in padding on the combined
> items (cut/copy/paste, zoom in/out/reset) as compared to the current state
> on OS X (they've gone from roughly 29 pixels between lines to 33 pixels
> between lines) - is that intentional and/or should that be applied
> everywhere rather than just on Yosemite?

This, too, wasn't an intentional change.

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> > Customize.png
> 
> Also, this is using color instead of pressed state for the menu button
> again. We previously switched back to using an actual pressed state because
> otherwise we have issues distinguishing between "checked" and hover/active
> states. Did you consider how e.g. the downloads and bookmark button states
> would look with this? Can you provide mockups for those, too? (I didn't find
> a comprehensive mockup of the different toolbar button states, I'm sorry if
> I missed it somewhere obvious)

We can leave this as-is instead of switching to the blue highlight.
Flags: needinfo?(mmaslaney)
Depends on: 1053176
Assignee: gijskruitbosch+bugs → nobody
Status: ASSIGNED → NEW
Iteration: 34.2 → ---
Points: 5 → ---
QA Whiteboard: [qa-]
Flags: firefox-backlog+
Summary: [10.10] Breakdown: Implement visual changes for OS X Yosemite → Tracking: Implement visual changes for OS X Yosemite
Depends on: 931040
No longer depends on: 1019587
Depends on: 1055614
No longer depends on: 1051522
Are we planning on refreshing icons and the application icons to be consistent with Yosemite's new look? Not sure our current Firefox app icon would look like it belonged.
(In reply to Benjamin Kerensa [:bkerensa] from comment #7)
> Are we planning on refreshing icons and the application icons to be
> consistent with Yosemite's new look? Not sure our current Firefox app icon
> would look like it belonged.

The in-app icons are tracked in bug 1050809. I don't think we're planning to update the app icon. I've not user Yosemite toooo much, but I don't think we "stick out" much, so I personally wouldn't feel that it's necessary to change there.
Agree that the app icons certainly shouldn't be a priority here. Actually I think the Nightly icon fits in nicely with the new round icon trend, even if the lighting is a little bit different from the HIG.
Depends on: 1057748
Depends on: 1059278
Depends on: 1059991
Depends on: 1060426
Depends on: 1060866
Depends on: 1060944
Depends on: 1061209
Alias: theme-yosemite
Depends on: 1063529
Depends on: 1065429
Depends on: 1069658
No longer depends on: 1061209
Depends on: 1070038
Depends on: 1068702
No longer depends on: 1068702
Depends on: 1072992
Depends on: 1075653
Depends on: 1076252
Depends on: 1075672
Depends on: 1077358
Depends on: 1079402
Depends on: 1081160
Depends on: 1082002
Release Note Request (optional, but appreciated)
[Why is this notable]: Support for new version of OSX
[Suggested wording]: OS X 10.10 Yosemite support
[Links (documentation, blog post, etc)]:

I would like to note this in Firefox 34 as we have made a good number of improvements in this release and this is the first release that will ship after Yosemite's release.
relnote-firefox: --- → ?
Blocks: 1084982
Depends on: 1086965
Depends on: 1091678
Depends on: 1092939
Depends on: 1100246
Depends on: 1100401
Depends on: 1101236
Depends on: 1102710
Depends on: 1102823
Depends on: 1102801
Depends on: 1106906
No longer depends on: 1102710
Depends on: 1152288
Depends on: 1188942
Depends on: 1196707
Depends on: 1196715
Depends on: 1251019
Depends on: 1287763
Type: defect → enhancement
Summary: Tracking: Implement visual changes for OS X Yosemite → [meta] Tracking: Implement visual changes for OS X Yosemite
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.