Bug 1040250 (theme-yosemite)

[meta] Tracking: Implement visual changes for OS X Yosemite

NEW
Unassigned

Status

()

enhancement
5 years ago
14 days ago

People

(Reporter: phlsa, Unassigned)

Tracking

(Depends on 10 bugs, {meta})

33 Branch
x86
macOS
Points:
---

Firefox Tracking Flags

(relnote-firefox 34+)

Details

(Whiteboard: [yosemite])

Bug 1020551 has mockups for the style changes needed in order to integrate nicely with the new OS X release.
This is the corresponding breakdown bug for the implementation.
Flags: firefox-backlog+
QA Whiteboard: [qa-]

Comment 1

5 years ago
Should it be the other way around, that bug 1044595 blocks this one? Meta bugs are fixed by fixing the dependencies, not what it blocks.

Updated

5 years ago
No longer blocks: 1044595
Depends on: 1044595

Updated

5 years ago
Keywords: meta

Updated

5 years ago
Summary: Breakdown: Implement visual changes for OS X Yosemite → [10.10] Breakdown: Implement visual changes for OS X Yosemite

Updated

5 years ago
Depends on: 1044601, 1042338, 1042331

Updated

5 years ago
Whiteboard: [yosemite]

Updated

5 years ago
Depends on: 1044258

Updated

5 years ago
Depends on: 1045201

Updated

5 years ago
Depends on: 1045206

Updated

5 years ago
Depends on: 1045213

Updated

5 years ago
Depends on: 1045217

Updated

5 years ago
Depends on: 1019587

Updated

5 years ago
Depends on: 1047828
Points: --- → 5

Updated

5 years ago
Depends on: 1050804

Updated

5 years ago
Depends on: 1050807

Comment 2

5 years ago
Nicking this. Marco, can you update the spreadsheet? Thanks!
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 34.2
Flags: needinfo?(mmucci)

Updated

5 years ago
Depends on: 1050809

Comment 3

5 years ago
Michael, can you clarify something? These mockups:

http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-Customize.png
https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728

seem to be using different toolbar icons. Can you clarify what the difference there is, or if that was an oversight?

I also noticed that there seems to be a change in padding on the combined items (cut/copy/paste, zoom in/out/reset) as compared to the current state on OS X (they've gone from roughly 29 pixels between lines to 33 pixels between lines) - is that intentional and/or should that be applied everywhere rather than just on Yosemite?
Flags: needinfo?(mmaslaney)

Comment 4

5 years ago
(In reply to :Gijs Kruitbosch from comment #3)
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png

Also, this is using color instead of pressed state for the menu button again. We previously switched back to using an actual pressed state because otherwise we have issues distinguishing between "checked" and hover/active states. Did you consider how e.g. the downloads and bookmark button states would look with this? Can you provide mockups for those, too? (I didn't find a comprehensive mockup of the different toolbar button states, I'm sorry if I missed it somewhere obvious)

Updated

5 years ago
Depends on: 1050816
Added to Iteration 34.2
Flags: needinfo?(mmucci)

Updated

5 years ago
Depends on: 1051522

Updated

5 years ago
Depends on: 1052466

Updated

5 years ago
Depends on: 1052522

Updated

5 years ago
Depends on: 1052527

Updated

5 years ago
Depends on: 1052534

Updated

5 years ago
No longer depends on: 1044258

Updated

5 years ago
Depends on: 1053073

Comment 6

5 years ago
Posting in replies from my meeting with mmaslaney:

(In reply to :Gijs Kruitbosch from comment #3)
> Michael, can you clarify something? These mockups:
> 
> http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> Customize.png
> https://bug1020551.bugzilla.mozilla.org/attachment.cgi?id=8440728
> 
> seem to be using different toolbar icons. Can you clarify what the
> difference there is, or if that was an oversight?

The fade-out in customize mode wasn't an intentional part of the design, so we can leave the buttons as they are in customize mode.

> I also noticed that there seems to be a change in padding on the combined
> items (cut/copy/paste, zoom in/out/reset) as compared to the current state
> on OS X (they've gone from roughly 29 pixels between lines to 33 pixels
> between lines) - is that intentional and/or should that be applied
> everywhere rather than just on Yosemite?

This, too, wasn't an intentional change.

(In reply to :Gijs Kruitbosch from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > http://people.mozilla.org/~mmaslaney/firefox/Australis-OSX-Yosemite-
> > Customize.png
> 
> Also, this is using color instead of pressed state for the menu button
> again. We previously switched back to using an actual pressed state because
> otherwise we have issues distinguishing between "checked" and hover/active
> states. Did you consider how e.g. the downloads and bookmark button states
> would look with this? Can you provide mockups for those, too? (I didn't find
> a comprehensive mockup of the different toolbar button states, I'm sorry if
> I missed it somewhere obvious)

We can leave this as-is instead of switching to the blue highlight.

Updated

5 years ago
Flags: needinfo?(mmaslaney)

Updated

5 years ago
Depends on: 1053176

Updated

5 years ago
Assignee: gijskruitbosch+bugs → nobody
Status: ASSIGNED → NEW
Iteration: 34.2 → ---
Points: 5 → ---
QA Whiteboard: [qa-]
Flags: firefox-backlog+
Summary: [10.10] Breakdown: Implement visual changes for OS X Yosemite → Tracking: Implement visual changes for OS X Yosemite
Depends on: 931040
No longer depends on: 1019587
Depends on: 1055614
No longer depends on: 1051522
Are we planning on refreshing icons and the application icons to be consistent with Yosemite's new look? Not sure our current Firefox app icon would look like it belonged.

Comment 8

5 years ago
(In reply to Benjamin Kerensa [:bkerensa] from comment #7)
> Are we planning on refreshing icons and the application icons to be
> consistent with Yosemite's new look? Not sure our current Firefox app icon
> would look like it belonged.

The in-app icons are tracked in bug 1050809. I don't think we're planning to update the app icon. I've not user Yosemite toooo much, but I don't think we "stick out" much, so I personally wouldn't feel that it's necessary to change there.
Agree that the app icons certainly shouldn't be a priority here. Actually I think the Nightly icon fits in nicely with the new round icon trend, even if the lighting is a little bit different from the HIG.

Updated

5 years ago
Depends on: 1057748
Depends on: 1059278

Updated

5 years ago
Depends on: 1059991

Updated

5 years ago
Depends on: 1060426

Updated

5 years ago
Depends on: 1060866

Updated

5 years ago
Depends on: 1060944

Updated

5 years ago
Depends on: 1061209

Updated

5 years ago
Alias: theme-yosemite

Updated

5 years ago
Depends on: 1063529

Updated

5 years ago
Depends on: 1065429
Depends on: 1069658
No longer depends on: 1061209
Depends on: 1070038

Updated

5 years ago
Depends on: 1068702

Updated

5 years ago
No longer depends on: 1068702

Updated

5 years ago
Depends on: 1072992

Updated

5 years ago
Depends on: 1075653

Updated

5 years ago
Depends on: 1076252

Updated

5 years ago
Depends on: 1075672
Depends on: 1077358

Updated

5 years ago
Depends on: 1079402
Depends on: 1081160
Depends on: 1082002
Release Note Request (optional, but appreciated)
[Why is this notable]: Support for new version of OSX
[Suggested wording]: OS X 10.10 Yosemite support
[Links (documentation, blog post, etc)]:

I would like to note this in Firefox 34 as we have made a good number of improvements in this release and this is the first release that will ship after Yosemite's release.
relnote-firefox: --- → ?

Updated

5 years ago
Blocks: 1084982

Updated

5 years ago
Depends on: 1086965

Updated

5 years ago
Depends on: 1091678

Updated

5 years ago
Depends on: 1092939

Updated

5 years ago
Depends on: 1100246

Updated

5 years ago
Depends on: 1100401

Updated

5 years ago
Depends on: 1101236

Updated

5 years ago
Depends on: 1102710

Updated

5 years ago
Depends on: 1102823

Updated

5 years ago
Depends on: 1102801

Updated

4 years ago
Depends on: 1106906

Updated

4 years ago
No longer depends on: 1102710

Updated

4 years ago
Depends on: 1152288

Updated

4 years ago
Depends on: 1188942
Depends on: 1196707
Depends on: 1196715

Updated

3 years ago
Depends on: 1251019

Updated

3 years ago
Depends on: 1287763
Type: defect → enhancement
Summary: Tracking: Implement visual changes for OS X Yosemite → [meta] Tracking: Implement visual changes for OS X Yosemite
You need to log in before you can comment on or make changes to this bug.