If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Webmaker
Events
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gvn, Assigned: gvn)

Tracking

Details

(Whiteboard: [events] [aug8])

Attachments

(2 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8458177 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/76

I'll need to make a frontend patch too which uses superuserId instead of userId.
Attachment #8458177 - Flags: review?(jon)
(Assignee)

Comment 2

3 years ago
Created attachment 8458192 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/147
Attachment #8458192 - Flags: review?(jon)
Whiteboard: [july25] → [events] [july25]
(Assignee)

Comment 3

3 years ago
Ok, refactored to use Cade's new bespoke-SQL query approach.

Comment 4

3 years ago
Comment on attachment 8458192 [details] [review]
https://github.com/mozilla/webmaker-events-2/pull/147

notes in the PR
Attachment #8458192 - Flags: review?(jon) → review-

Comment 5

3 years ago
Comment on attachment 8458177 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/76

r- because we're going to Promisify webmaker-user-client and hopefully make all the whitespace changes go away
Attachment #8458177 - Flags: review?(jon) → review-
(Assignee)

Comment 6

3 years ago
Can you set the ticket for promisifying WUC as a blocker here?
Flags: needinfo?(jon)

Updated

3 years ago
Depends on: 1045036

Comment 7

3 years ago
Done and added a patch
Status: NEW → ASSIGNED
Flags: needinfo?(jon)
(Assignee)

Updated

3 years ago
Whiteboard: [events] [july25] → [events] [aug8]
(Assignee)

Comment 8

3 years ago
Created attachment 8464324 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/90
Attachment #8458177 - Attachment is obsolete: true
Attachment #8464324 - Flags: review?(jon)
(Assignee)

Updated

3 years ago
Attachment #8458192 - Flags: review- → review?(jon)
(Assignee)

Comment 9

3 years ago
Re-done w. promises and a bit less gross...

Updated

3 years ago
Attachment #8458192 - Flags: review?(jon) → review-

Updated

3 years ago
Attachment #8464324 - Flags: review?(jon) → review-
From IRC: [13:45:11]  <@jbuck>	 gvn: so, I think we're on the same page, but just to verify... we have a new search parameter (can we please call it username so it's self-descriptive? :)). When you search for events by username, it'll hit up the webmaker user client for the user id. then it'll do an Events.organizerId (username) || Organizer.userId (userId) || Mentor.userId (userId) search
(Assignee)

Updated

3 years ago
Attachment #8458192 - Flags: review- → review?(jon)
(Assignee)

Updated

3 years ago
Attachment #8464324 - Flags: review- → review?(jon)

Updated

3 years ago
Attachment #8458192 - Flags: review?(jon) → review+

Updated

3 years ago
Attachment #8464324 - Flags: review?(jon) → review+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.