Closed Bug 1040391 Opened 6 years ago Closed 6 years ago

Fix test_bug440572.html to not rely on silent failure to pass

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
dom/tests/mochitest/bugs/test_bug440572.html is supposed to test access through Xrays to iframes by name, even if they would shadow a WebIDL property. We've switched away from that behaviour, so it should be failing. It doesn't fail because the code that deals with the exception from accessing the property tries to postMessage the exception directly, which throws another exception. The test doesn't count the number of messages it gets, so the missing postMessage's are just ignored.
Attachment #8458319 - Flags: review?(bzbarsky)
Comment on attachment 8458319 [details] [diff] [review]
v1

r=me
Attachment #8458319 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/f89bd78b1fc7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.