1040393 - Successfully vouched user text should be removed when vouching a user with 6+ vouches

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Vuyisile Ndlovu [:terrameijar]]

User Agent: Opera/9.80 (X11; Linux i686) Presto/2.12.388 Version/12.15

Steps to reproduce:

Attempt to vouch a user with 6 vouches already


Actual results:

You get this message: Successfully vouched user. 


Expected results:

Notify  the person vouching that this user has already been vouched 6 times. Or a message along the lines of so and so is already a core contributor

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Vuyisile,

Thank you for reporting. I assume that you used the /vouch mechanism (bug 1038076) to vouch?

Note:
removed the "vouching rel. 1" whiteboard note as this is not blocking release. This feature is only for testers. Added blocker to tracker bug.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/98efbda56fe93f9d447fd95ad533f4320301da2b
[fix bug 1040393] Display error message when user doesn't get vouched.

https://github.com/mozilla/mozillians/commit/738dd9835ede9eb594f49b95bdce84858fe34485
Merge pull request #1045 from glogiotatidis/1040393

[fix bug 1040393] Display error message when user doesn't get vouched.

Comment 3

[Vuyisile Ndlovu [:terrameijar]]

Giorgos, yes, that's the mechanism I used

Comment 4

[Tasos Katsoulas [:tasos]]

Verified on stage.

Verification steps.
* Added 6 vouches on the account [0] through the /vouch mechanish, during which there was a message verifying that the account was vouched.
* On the 7th attempt, the account wasn't vouched and a message saying 'User not vouched. Maybe there are 6 vouches already?' appeared.

[0] https://mozillians.allizom.org/en-US/u/akatsoulas/