Closed
Bug 104052
Opened 23 years ago
Closed 23 years ago
LRE stylesheets are cool
Categories
(Core :: XSLT, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: sicking, Assigned: sicking)
References
()
Details
Attachments
(3 files, 1 obsolete file)
178 bytes,
text/xml
|
Details | |
150 bytes,
text/xml
|
Details | |
12.45 KB,
patch
|
sicking
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
patch that implements lre stylesheets are coming up...
Assignee | ||
Comment 1•23 years ago
|
||
just to beat Pike to it... Some of this code is sub-optimal until ns-doom has landed
Status: NEW → ASSIGNED
Depends on: 76070
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
*** Bug 104789 has been marked as a duplicate of this bug. ***
Comment 6•23 years ago
|
||
Comment on attachment 52905 [details] [diff] [review] here goes... Rename processTopLevel (to processStylesheet or something better), move "stylesheet" and "transform" into Names.*. With those changes, r=peterv.
Attachment #52905 -
Flags: review+
Assignee | ||
Comment 7•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Attachment #53581 -
Flags: review+
Assignee | ||
Updated•23 years ago
|
Attachment #52905 -
Attachment is obsolete: true
Comment 8•23 years ago
|
||
Comment on attachment 53581 [details] [diff] [review] addresses comments from peterv rs=brendan@mozilla.org Code looks ok (prevailing style suppresses out of memory errors, not sure that matters in practice). The Map and NamedMap hash tables will perform poorly under load. Use xpcom/ds/pldhash.h as their implementation basis instead. /be
Attachment #53581 -
Flags: superreview+
Assignee | ||
Comment 9•23 years ago
|
||
checked in Thanks for reviews!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•