1040553 - No option to upload webmaker profile picture

Status: RESOLVED FIXED

(Webmaker Graveyard :: Profile, defect)

Description

[Tanay Pant [:Tanay]]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

1. Log in to your account using persona.
2. Under your username in the top right corner, from the drop down list select my profile.

Eg: https://webmaker.org/user/tanay1337


Actual results:

In the profile there is no option to change/ upload new profile images.


Expected results:

There should have been some explanation, saying either that the profile picture is linked from discourse or gravatar, or there should have been an option to upload a new picture or link an image through URL.

Comment 1

[Lawrence Kisuuki]

Hello,

Jumping in to see if I can help? Did you get this resolved?

Thanks.

Comment 2

[Jon Buckley [:jbuck]]

No, this hasn't been resolved. If someone wants to take it on, I'm happy to mentor though!

Comment 3

[Tanay Pant [:Tanay]]

No, this problem has not been resolved.

Comment 4

[Jon Buckley [:jbuck]]

Alright Tanay, if you'd like to take this on you'll need to clone https://github.com/mozilla/webmaker-profile-2 . You'll need to add some localizable text underneath the the avatar, somewhere around https://github.com/mozilla/webmaker-profile-2/blob/master/app/index.html#L65 . This text should probably only be shown in edit mode.

Comment 5

[Tanay Pant [:Tanay]]

Attachment: https://github.com/mozilla/webmaker-profile-2/pull/58

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 8464094 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/58

This looks good, but I can't check out your branch on Github for some reason.

Comment 7

[Tanay Pant [:Tanay]]

Attachment: https://github.com/mozilla/webmaker-profile-2/pull/58

Made the required changes!

Comment 8

[Tanay Pant [:Tanay]]

Attachment: https://github.com/mozilla/webmaker-profile-2/pull/59

Now you should be able to merge the PR :)

Comment 9

[Chris DeCairos (:cade)]

Comment on attachment 8464460 [details] [review]
https://github.com/mozilla/webmaker-profile-2/pull/59

Looks great!

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker-profile-2

https://github.com/mozilla/webmaker-profile-2/commit/4efeea31c27a59b1fd4128c797915fab27cc9a51
Fixed Bug 1040553

Fixed Bug 1040553

https://github.com/mozilla/webmaker-profile-2/commit/c68108d9f0a3e285bbe77ad03a2d2720f84fd1c4
Merge pull request #59 from tanay1337/master

Fixed Bug 1040553