The size of the datetime items in add event view are not correct

VERIFIED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Calendar
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: evanxd, Assigned: evanxd)

Tracking

({regression})

unspecified
2.1 S1 (1aug)
ARM
Gonk (Firefox OS)
regression

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v2.0 verified, b2g-v2.1 verified)

Details

Attachments

(4 attachments)

(Assignee)

Description

3 years ago
Created attachment 8458412 [details]
datetime-items-too-big.png

Please refer to the attachment to see the issue.
Master or 2.0?
Reproduced on my devices

Flame v2.1 master
Gecko     https://hg.mozilla.org/mozilla-central/rev/e9cdcf646d1c
BuildID   20140720160202
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Flame v2.0 aurora
Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c6f9f0396153
BuildID   20140720160208
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM

Updated

3 years ago
QA Contact: edchen
(Assignee)

Comment 3

3 years ago
Hi Miller,

It could be reproduced on current master and 2.0.

Gaia version:
master: ecca261792527faa7a769145f1f854f77336c064
2.0: b9d19011123487009c80d1200937652d58c434a0
if it's on 2.0 it should be a blocker in my opinion
blocking-b2g: --- → 2.0?
blocking-b2g: 2.0? → 2.0+
Target Milestone: --- → 2.1 S1 (1aug)
https://github.com/mozilla-b2g/gaia/commit/7015e7b82c7f8550bfaaec25a14ecd5a0dd35503 is the first bad commit. Regression introduced by Bug 1036147
See Also: → bug 1036147

Comment 6

3 years ago
Created attachment 8459826 [details]
screenshot

Reproduced on 2.0 build on Flame.   See screenshot.

Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c6f9f0396153
BuildID   20140720160208
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Updated

3 years ago
Keywords: regression
(Assignee)

Comment 7

3 years ago
Created attachment 8459866 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004
(Assignee)

Comment 8

3 years ago
Comment on attachment 8459866 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004

Hi Miller,

Could you help to review the patch?

Thanks.
Attachment #8459866 - Flags: review?(mmedeiros)
Comment on attachment 8459866 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004

LGTM, basically the same thing as Clock app does.
Attachment #8459866 - Flags: review?(mmedeiros) → review+
(Assignee)

Comment 10

3 years ago
Thanks, Miller.
(Assignee)

Comment 11

3 years ago
master: 3078ac2ebdf8b4af42136f3943b32b8f4ce460b0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
v2.0: https://github.com/mozilla-b2g/gaia/commit/91986777d0942b63e37fbfeec19d69d6176d6d74
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
PASS
Status: RESOLVED → VERIFIED

Comment 14

3 years ago
This issue has been verified successfully on Flame 2.0

See attachment: Verify_image.png
Reproducing rate: 0/5
FLame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0
status-b2g-v2.0: fixed → verified
status-b2g-v2.1: fixed → verified

Comment 15

3 years ago
Created attachment 8531411 [details]
Verify_image.png
You need to log in before you can comment on or make changes to this bug.