1040563 - Firefox process remains forever after quit browser if set media.mediasource.enabled = true.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Open http://www.youtube.com/watch?v=eYDjV7ajuMo
2. Wait buffering

3. Moving seek-bar back or forward
4. Repeat step 3 until video stops playback and throbber is continuing spinning.

5. Quit browser

Actual Results:
Firefox process remains forever

Expected Results:
Firefox process should immediately disappears

Stack on shutdown hang(using crashfirefox.exe):
bp-6ef69880-134c-417a-87b4-e21d52140718

Comment 1

[Alice0775 White]

Addition to step3:
Moving within buffered range

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

It gets stuck in MediaSource::WaitForData() while MediaDecoderStateMachine is running SHUTDOWN. I wonder if there is a way to tell MediaSource to abort WaitForData() for SourceBuffer::AppendData() could be never called again during shutdown.

Hi Anthony,
Can you comment this? I am not familiar with the MediaSource code.

Comment 3

[Alice0775 White]

Oops, I fogot to set media.mediasource.enabled = true.
The prefs causes the problem.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

(In reply to JW Wang [:jwwang] from comment #2)
> Can you comment this? I am not familiar with the MediaSource code.

I've added it to the things we need to fix in relation to MediaSource.

Comment 5

[Matthew Gregan [:kinetik]]

Could be fixed by bug 1056441, or (shorter term) by breaking the wait on shutdown.

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: Move WaitForData/NotifyGotData from MediaSource to MediaSourceDecoder, which is off-main-thread friendly.

Also remove mMediaSource from MediaSourceReader and rejig SetMediaSourceDuration to go via MediaSourceDecoder and handle mMediaSource being null.

Comment 7

[cajbir (:cajbir)]

Comment on attachment 8477317 [details] [diff] [review]
Move WaitForData/NotifyGotData from MediaSource to MediaSourceDecoder, which is off-main-thread friendly.

Review of attachment 8477317 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceDecoder.cpp
@@ +94,5 @@
> +MediaSourceDecoder::Shutdown()
> +{
> +  MediaDecoder::Shutdown();
> +
> +  // Kick WaitForData out of it's slumber.

s/it's/its/

Comment 8

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c94c5407b1c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c94c5407b1c