Firefox process remains forever after quit browser if set media.mediasource.enabled = true.

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alice0775, Assigned: kinetik)

Tracking

(Blocks 1 bug)

32 Branch
mozilla34
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Steps To Reproduce:
1. Open http://www.youtube.com/watch?v=eYDjV7ajuMo
2. Wait buffering

3. Moving seek-bar back or forward
4. Repeat step 3 until video stops playback and throbber is continuing spinning.

5. Quit browser

Actual Results:
Firefox process remains forever

Expected Results:
Firefox process should immediately disappears

Stack on shutdown hang(using crashfirefox.exe):
bp-6ef69880-134c-417a-87b4-e21d52140718
See Also: → 1040552
Addition to step3:
Moving within buffered range
Version: Trunk → 32 Branch
It gets stuck in MediaSource::WaitForData() while MediaDecoderStateMachine is running SHUTDOWN. I wonder if there is a way to tell MediaSource to abort WaitForData() for SourceBuffer::AppendData() could be never called again during shutdown.

Hi Anthony,
Can you comment this? I am not familiar with the MediaSource code.
Flags: needinfo?(ajones)
Oops, I fogot to set media.mediasource.enabled = true.
The prefs causes the problem.
Summary: Firefox process remains forever after quit browser → Firefox process remains forever after quit browser if set media.mediasource.enabled = true.
Blocks: MSE
Flags: needinfo?(ajones)
(In reply to JW Wang [:jwwang] from comment #2)
> Can you comment this? I am not familiar with the MediaSource code.

I've added it to the things we need to fix in relation to MediaSource.
Blocks: 1056440
Could be fixed by bug 1056441, or (shorter term) by breaking the wait on shutdown.
Depends on: 1056441
Also remove mMediaSource from MediaSourceReader and rejig SetMediaSourceDuration to go via MediaSourceDecoder and handle mMediaSource being null.
Attachment #8477317 - Flags: review?(cajbir.bugzilla)
Comment on attachment 8477317 [details] [diff] [review]
Move WaitForData/NotifyGotData from MediaSource to MediaSourceDecoder, which is off-main-thread friendly.

Review of attachment 8477317 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/mediasource/MediaSourceDecoder.cpp
@@ +94,5 @@
> +MediaSourceDecoder::Shutdown()
> +{
> +  MediaDecoder::Shutdown();
> +
> +  // Kick WaitForData out of it's slumber.

s/it's/its/
Attachment #8477317 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/2c94c5407b1c
Assignee: nobody → kinetik
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.