1040575 - copy SVGSVGElement.currentTranslate if we insert it into an SVGPointList

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

While looking at bug 1018524 I noticed that we also don't make a copy of SVGSVGElement.currentTranslate, an SVGPoint, if we try to insert it into a list.  I don't think this results in anything harmful (we don't have a tearoff table for SVGPoints) other than an odd coupling of currentTranslate and say a <polyline points=""> attribute, but I'm hiding this bug while bug 1018524 is still hidden.

I've changed Clone to Copy, to match the naming on SVGLengthList, and changed it to always return an SVGDOMPoint as it looks like the return-the-same-concrete-class behaviour isn't being relied upon.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: test

Meant to include this test too.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Landed at longsonr's request in bug 1018524. Should we backport this to the release branches as well or is it OK landing on trunk only?

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d871044fe8

Comment 3

[Robert Longson [:longsonr]]

It wants landing everywhere we land bug 1018524 it's potentially a similar hole although we've no known exploit so if you know about one (and everyone does now) you just might be able to use that knowledge here.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8458436 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 886416 (31+)
[User impact if declined]: see comment 3
[Describe test coverage new/current, TBPL]: includes a test
[Risks and why]: low
[String/UUID change made/needed]: none

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Given that this is rated sec-other, let's let this land on m-c before uplift.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b4d871044fe8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c6fff1b1200
https://hg.mozilla.org/releases/mozilla-beta/rev/4da65dc7d057
https://hg.mozilla.org/releases/mozilla-esr31/rev/e52d2055fbb2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/4da65dc7d057

Comment 9

[Kamil Jozwiak [:kjozwiak]]

There's no poc code or an exploitable bug that can be used for testing and verification. If there's something QE can do to test/verify this issue, please let us know and needinfo! Marking this as qe-verify- for the time being. (also as per comment #3, we currently don't have a known exploit)