1040589 - [tarako]show wrong operator name on drop-down menu of status bar and looked screen.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[孟宪茂]

steps to reproduce:

a)Insert sim card(Grameenphone 470-01) and sim card camp properly.
b)tarako shows GP instead of Grameenphone on drop-down menu of status bar（developed by sprd） and looked screen.

Comment 1

[孟宪茂]

Besides,many other operators also show the unfriendly name,all this operator name comes from network.
we should make a operator name table,and show the friendly operator name from the table.

The follow attachment is the plmn.json file which is used to store friendly operator name.

Comment 2

[孟宪茂]

Attachment: plmn.json

Comment 3

[孟宪茂]

Attachment: operator_name.patch

This patch is made to show the operator name from plmn.json for drop-down menu of status bar and looked screen.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8458486 [details] [diff] [review]
operator_name.patch

Review of attachment 8458486 [details] [diff] [review]:
-----------------------------------------------------------------

Too many lint errors.
No any tests.

I don't know how to review it. Sorry.

::: apps/system/js/lockscreen_connection_info_manager.js
@@ +258,4 @@
>          return;
>        }
>  
> +            var jsonLoader = function loadJSON(href, callback) {

lint

@@ +258,5 @@
>          return;
>        }
>  
> +            var jsonLoader = function loadJSON(href, callback) {
> +        if (!callback)

{

@@ +259,5 @@
>        }
>  
> +            var jsonLoader = function loadJSON(href, callback) {
> +        if (!callback)
> +          return;

}

@@ +260,5 @@
>  
> +            var jsonLoader = function loadJSON(href, callback) {
> +        if (!callback)
> +          return;
> +        console.log("--> mxm_function loadJSON...href now is " + href);

don't log anything by default.

::: apps/system/js/operator_name.js
@@ +1,5 @@
> +'use strict';
> +
> +var operatorName = {
> +
> +PLMN_FILE: '/shared/resources/plmn.json',

lint

@@ +3,5 @@
> +var operatorName = {
> +
> +PLMN_FILE: '/shared/resources/plmn.json',
> +
> +jsonLoader:function loadJSON(href, callback) {

why do you implement the same function again?

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

IMHO the patch seems better to stay in the local branch. We should not overwrite the original service provider names at will.

Comment 6

[BMO Automation]

Firefox OS is not being worked on