If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Waiting for web page to load in test_cost_control_data_alert_mobile

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: AndreiH, Assigned: AndreiH)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.0 affected)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
Bebe
: review+
viorela
: review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
http://jenkins1.qa.scl3.mozilla.com/job/flame.mozilla-aurora.ui.functional.smoke/17/HTML_Report/

As you can see in failure from the HTML report, "Data usage bar did not breach limit". I suspect that the page couldn't load completely, or there was some kind of error from the page(Error 404 or smth) (loaded data 5.12 kb), and we cannot know for sure.

Let's add a wait for the page to load, that way the test will fail a step before and we will know if there was something wrong loading the webpage.
(Assignee)

Comment 1

3 years ago
Zac does this seem ok to you?
Flags: needinfo?(zcampbell)

Comment 2

3 years ago
OK but I thought we did have a wait for the page to load, inside the Browser app object.
Flags: needinfo?(zcampbell)
(Assignee)

Comment 3

3 years ago
Created attachment 8458659 [details] [review]
Master PR
Attachment #8458659 - Flags: review?(zcampbell)
Attachment #8458659 - Flags: review?(florin.strugariu)
(Assignee)

Updated

3 years ago
status-b2g-v2.0: --- → affected
(Assignee)

Updated

3 years ago
Assignee: nobody → andrei.hutusoru
Priority: -- → P2

Comment 4

3 years ago
Comment on attachment 8458659 [details] [review]
Master PR

This wait is already done inside tap_go_button in the Browser app object. Are you sure this fixes anything?
Attachment #8458659 - Flags: review?(zcampbell) → review-

Comment 5

3 years ago
AndreiH, why don't you make sure that `go_to_url` fails even if there's no internet?
(Assignee)

Comment 6

3 years ago
Ups, didn't saw that there was already a wait there. So I need to make sure that an element from the page that loads is visible, that way if there's no internet the test will fail on that step.
Attachment #8458659 - Flags: review?(florin.strugariu) → review-
(Assignee)

Comment 7

3 years ago
Comment on attachment 8458659 [details] [review]
Master PR

This will make sure that test will fail even if there is no internet.
Attachment #8458659 - Flags: review?(zcampbell)
Attachment #8458659 - Flags: review?(florin.strugariu)
Attachment #8458659 - Flags: review-
Attachment #8458659 - Flags: review?(florin.strugariu) → review+
This is also happening on the latest tinderbox build, both test_browser_cell_data.py and test_cost_control_data_alert_mobile have failed: http://jenkins1.qa.scl3.mozilla.com/job/flame.b2g-inbound.ui.functional.smoke/230/HTML_Report/

Gaia      cd50cb6ddeb430ddaf43e4fcf5774b9d262a8cf3
Gecko     https://hg.mozilla.org/integration/b2g-inbound/rev/bc0aa44b2885
BuildID   20140722045629
Version   34.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
Comment on attachment 8458659 [details] [review]
Master PR

Lgtm, r+
Attachment #8458659 - Flags: review+
Merged: https://github.com/mozilla-b2g/gaia/commit/85b03136a6744fb98c12f22e44e4e391944e5b0d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Attachment #8458659 - Flags: review?(zcampbell)
You need to log in before you can comment on or make changes to this bug.