1040732 - Waiting for web page to load in test_cost_control_data_alert_mobile

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[[:AndreiH]]

http://jenkins1.qa.scl3.mozilla.com/job/flame.mozilla-aurora.ui.functional.smoke/17/HTML_Report/

As you can see in failure from the HTML report, "Data usage bar did not breach limit". I suspect that the page couldn't load completely, or there was some kind of error from the page(Error 404 or smth) (loaded data 5.12 kb), and we cannot know for sure.

Let's add a wait for the page to load, that way the test will fail a step before and we will know if there was something wrong loading the webpage.

Comment 1

[[:AndreiH]]

Zac does this seem ok to you?

Comment 2

[Zac C (:zac)]

OK but I thought we did have a wait for the page to load, inside the Browser app object.

Comment 3

[[:AndreiH]]

Attachment: Master PR

Comment 4

[Zac C (:zac)]

Comment on attachment 8458659 [details] [review]
Master PR

This wait is already done inside tap_go_button in the Browser app object. Are you sure this fixes anything?

Comment 5

[Zac C (:zac)]

AndreiH, why don't you make sure that `go_to_url` fails even if there's no internet?

Comment 6

[[:AndreiH]]

Ups, didn't saw that there was already a wait there. So I need to make sure that an element from the page that loads is visible, that way if there's no internet the test will fail on that step.

Comment 7

[[:AndreiH]]

Comment on attachment 8458659 [details] [review]
Master PR

This will make sure that test will fail even if there is no internet.

Comment 8

[Viorela Ioia [:viorela]]

This is also happening on the latest tinderbox build, both test_browser_cell_data.py and test_cost_control_data_alert_mobile have failed: http://jenkins1.qa.scl3.mozilla.com/job/flame.b2g-inbound.ui.functional.smoke/230/HTML_Report/

Gaia      cd50cb6ddeb430ddaf43e4fcf5774b9d262a8cf3
Gecko     https://hg.mozilla.org/integration/b2g-inbound/rev/bc0aa44b2885
BuildID   20140722045629
Version   34.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014

Comment 9

[Viorela Ioia [:viorela]]

Comment on attachment 8458659 [details] [review]
Master PR

Lgtm, r+

Comment 10

[Viorela Ioia [:viorela]]

Merged: https://github.com/mozilla-b2g/gaia/commit/85b03136a6744fb98c12f22e44e4e391944e5b0d