Closed Bug 1040774 Opened 6 years ago Closed 6 years ago

Flatten away idl/public/src directories under rdf/

Categories

(Core Graveyard :: RDF, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: poiru, Assigned: poiru)

Details

Attachments

(1 file, 3 obsolete files)

This is similar to e.g. bug 1028559 and bug 946065.

Axel, would you be OK with this?
Flags: needinfo?(axel)
Yep, based on the comments by roc, jst, ehsan for the content->dom bug, I'll follow their lead gladly.
Flags: needinfo?(axel)
Attachment #8458717 - Flags: review?(axel)
Attachment #8458718 - Flags: review?(axel)
Can you just create one patch for all of RDF here?

I think that'd be easier to review, and I found a bit of back-and-forth in the moz.build files, too.
(In reply to Axel Hecht from comment #5)
> Can you just create one patch for all of RDF here?

Done.
Attachment #8458717 - Attachment is obsolete: true
Attachment #8458718 - Attachment is obsolete: true
Attachment #8458719 - Attachment is obsolete: true
Attachment #8458717 - Flags: review?(axel)
Attachment #8458718 - Flags: review?(axel)
Attachment #8458719 - Flags: review?(axel)
Attachment #8459549 - Flags: review?(axel)
This will conflict with bug 559505. Sync with Roberto?

Not sure how bad the conflict would really be, just want to call it out.
Comment on attachment 8459549 [details] [diff] [review]
Flatten rdf/{base,datasource,util}/{idl,public,src}/ directories

Review of attachment 8459549 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, one patch was in fact much easier to review.
Attachment #8459549 - Flags: review?(axel) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/12285ae78c93

Try push: https://tbpl.mozilla.org/?tree=Try&rev=4d762b578885

(In reply to Axel Hecht from comment #7)
> This will conflict with bug 559505. Sync with Roberto?
> 
> Not sure how bad the conflict would really be, just want to call it out.

Only one file in bug 559505 touches rdf/. I'll let him know.
https://hg.mozilla.org/mozilla-central/rev/12285ae78c93
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.