104079 - A C++ comment in C file blocking mozilla build on Solaris

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Joe Chou]

A C++ comment in a C file (../include/npapi.h, line 318) on mozilla094 branch
prevents the branch being build on Solaris using Forte. The problem only exists
on the 094 branch, not in the trunk. Since Sun is going to release Netscape 6.2
on the base of mozilla 094, it is critical to have this fix in the 094 branch.

Comment 1

[Joe Chou]

Attachment: Patch to remove the C++ mement.

Comment 2

[Joe Chou]

Assign to myself, since I've got the fix at hand. Also created attchment for the
fix (remove the C++ comment, as what has been done in trunk).

Comment 3

[Matthias Versen [:Matti]]

-> NEW

Comment 4

[Peter Lubczynski]

Comment on attachment 52941 [details] [diff] [review]
Patch to remove the C++ mement.

r=peterl

Comment 5

[Jim Dunn]

ugh... the comment is IN there for a purpose, you
can't just REMOVE it!

at least replace it with the CORRECT syntax

/* 10 and over are available on Mozilla builds starting with 0.9.4 */

I will ask...

Comment 6

[Peter Lubczynski]

Yeah, that's the way it is in the trunk and the branch should probably match.
However, competely removing the comment on the branch probably won't do any harm
as that branch will one day die anyway.

Comment 7

[Joe Chou]

Attachment: Second patch, coverted C++ to C comment, instead of removing it

Comment 8

[Joe Chou]

Attachment: Third patch, got the right patch file. (oops)

Comment 9

[Peter Lubczynski]

Comment on attachment 52956 [details] [diff] [review]
Third patch, got the right patch file. (oops)

ok, r=peterl

Comment 10

[Syd Logan]

Low risk, high reward (build bustage). Making nsbranch+, needs a super review.
Will review in PDT meeting this afternoon. Please work on getting the sr
(definitely a technicality in this case).

Comment 11

[Joe Chou]

I've sent email to Chris and Marc for sr=. 

Comment 12

[Joe Chou]

mkaply of IBM fixed the problem on the trunk. Therefore, the problem must have
broken OS2 build as well. 

Comment 13

[Marc Attinasi]

Comment on attachment 52956 [details] [diff] [review]
Third patch, got the right patch file. (oops)

sr=attinasi

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 52956 [details] [diff] [review]
Third patch, got the right patch file. (oops)

sr=blizzard

Comment 15

[Jaime Rodriguez, Jr.]

yeah ... let's look at this one today in the PDT.

Comment 16

[Jaime Rodriguez, Jr.]

pls check this into the 094 branch.

Comment 17

[Jaime Rodriguez, Jr.]

If this was checked into the 094 branch, pls change [Need ETA] to [FIX on 094 
branch]

Comment 18

[Jaime Rodriguez, Jr.]

Also, should this be reolved fixed for the 094 branch, and another bug opened 
for the trunk?

Comment 19

[Peter Lubczynski]

I just checked and this is already fixed on the trunk, 0.9.5 branch, and 0.9.4
branch. Marking FIXED.

Comment 20

[Joe Chou]

The fix has been checked into MOZILLA_0_9_4_BRANCH. And mkaply fixed the problem
on the trunk on Sep. 7th.

Comment 21

[Patty Mac]

Verified the patch.