1040819 - Bare Metal Provisioning 2008 Puppet: Disable Service Module Windows Support

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Comment 1

[Mark Cornmesser [:markco]]

Attachment: 1040819.patch

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8458733 [details] [diff] [review]
1040819.patch

Review of attachment 8458733 [details] [diff] [review]:
-----------------------------------------------------------------

Aside from the comment changes, this looks good.  If you edit the commit in your git repo, I'll cherry-pick it and land it.

::: modules/disableservices/manifests/disable_ms_maintenance.pp
@@ +1,4 @@
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +# All buildbot slaves (both build and test) are subclasses of this class.

Delete this line in each file in this patch.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Oops, I forgot I was waiting for another version.  I fixed up the comments in https://hg.mozilla.org/build/puppet/rev/b6735e645cea