Closed
Bug 1040822
Opened 11 years ago
Closed 11 years ago
Bare Metal Provisioning 2008 Puppet: Hardware module Windows support
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: markco, Unassigned)
Details
Attachments
(1 file)
2.18 KB,
patch
|
dustin
:
review+
dustin
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
Attachment #8458737 -
Flags: review?(dustin)
Comment 2•11 years ago
|
||
Comment on attachment 8458737 [details] [diff] [review]
1040822.patch
Review of attachment 8458737 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Same deal as before: I'll cherry-pick the edited version from your repo.
::: modules/hardware/manifests/hddoff.pp
@@ +1,4 @@
> +# This Source Code Form is subject to the terms of the Mozilla Public
> +# License, v. 2.0. If a copy of the MPL was not distributed with this
> +# file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +# All buildbot slaves (both build and test) are subclasses of this class.
More comments to delete :)
Attachment #8458737 -
Flags: review?(dustin) → review+
Updated•11 years ago
|
Attachment #8458737 -
Flags: checked-in+
Comment 3•11 years ago
|
||
Oops, I forgot I was waiting for another version. I fixed up the comments in https://hg.mozilla.org/build/puppet/rev/b6735e645cea
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•