Closed Bug 1040838 Opened 10 years ago Closed 10 years ago

cert.py will fail if build.prop value contains an equal sign

Categories

(Firefox OS Graveyard :: Certification Suite, defect)

Product:
Firefox OS Graveyard
Component:
Certification Suite
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: dminor)

References

Details

Attachments

(1 file)

Allow equal sign in build.prop value
54 bytes, text/x-github-pull-request
jgriffin
: review+
Details | Review 
cert.py contains a routine to dump B2G build props; this routine assumes that an individual line in build.props only contains 1 equals sign.

However, this isn't the case necessarily, e.g.,

   dalvik.vm.dexopt-flags=m=y

This value causes cert.py to die with the error:

   ValueError: too many values to unpack

from https://github.com/mozilla-b2g/fxos-certsuite/blob/master/certsuite/cert.py#L466
Assignee: nobody → dminor
Status: NEW → ASSIGNED

        Attachment #8458871 -
        Flags: review?(jgriffin)

    
  

        Attachment #8458871 -
        Flags: review?(jgriffin) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: