1040929 - Add button for reviewers to manually add approved apps to the re-review queue for investigation

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P3)

Description

[Lisa Brewster [:adora]]

Attachment: Button placement

Example workflow:  Review admin receives an abuse report that requires investigation.  Admin clicks a "re-review" button and enters text explaining the issue.  The app is then placed in the re-review queue, and should remain published until the investigation has been completed.  The actions a reviewer might take based on the results of this investigation are the same as what's already implemented in the re-review queue.

See attached screenshots for proposed UI.

Comment 1

[Lisa Brewster [:adora]]

Attachment: Comment box (same as report abuse)

Comment 2

[Andrew Williamson [:eviljeff]]

question: should the button (and the associated UX) be on the consumer page (like the mockups) or the reviewer page?  If on the reviewer page it could be another action - like clear rereview is.

Comment 3

[Andrew Williamson [:eviljeff]]

NI for Lisa: question: should the button (and the associated UX) be on the consumer page (like the mockups) or the reviewer page?  If on the reviewer page it could be another action - like clear rereview is.

Comment 4

[Lisa Brewster [:adora]]

Putting it on the reviewer page works, too.

Comment 5

[Andrew Williamson [:eviljeff]]

QA:
Pick an approved app, that isn't already in the re-review queue.
Use 'manual re-review' action
See that app is now in the re-review queue
In review history for that app it should show comments that indicate why the app was flagged for re-review.
Clear re-review and check its not in the re-review queue any more.

Comment 6

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/commit/eaefe397101286ac1b5a31aed90e08b28a22c9c0

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

(In reply to Andrew Williamson [:eviljeff] from comment #5)
> QA:
> Pick an approved app, that isn't already in the re-review queue.
> Use 'manual re-review' action
> See that app is now in the re-review queue
> In review history for that app it should show comments that indicate why the
> app was flagged for re-review.
> Clear re-review and check its not in the re-review queue any more.

After clearing the re-review, the changes should appear automatically? Because I've cleared the re-review for a newly submitted app, and it still appears in the Re-review queue after a quick search.
Please see the screencast: http://screencast.com/t/rvoN7nrc 
Until further notice, I'll reopen.

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to ValentinaP from comment #7)
> (In reply to Andrew Williamson [:eviljeff] from comment #5)
> > QA:
> > Pick an approved app, that isn't already in the re-review queue.
> > Use 'manual re-review' action
> > See that app is now in the re-review queue
> > In review history for that app it should show comments that indicate why the
> > app was flagged for re-review.
> > Clear re-review and check its not in the re-review queue any more.
> 
> After clearing the re-review, the changes should appear automatically?
> Because I've cleared the re-review for a newly submitted app, and it still
> appears in the Re-review queue after a quick search.
> Please see the screencast: http://screencast.com/t/rvoN7nrc 
> Until further notice, I'll reopen.

the search in your screencast is for 'published', not apps in the re-review queue.  And the review page shows its not in the re-review queue.

Comment 9

[Valentina Virlics [:vvalentina], VPN QA]

The search results from my screencast overrides the queue I am in to.
Verified on MP-dev FF42(Win 7).
Postfix screencast: http://screencast.com/t/by3U6oZgDFb 
Closing bug.