Add media [images, videos] to "Composing" page

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kat, Assigned: kat)

Tracking

Details

(Whiteboard: [resources] [aug8])

Attachments

(5 attachments)

(Assignee)

Description

4 years ago
Context: 
* Images bug discussion https://bugzilla.mozilla.org/show_bug.cgi?id=1018274
* Early work here https://etherpad.mozilla.org/webmakertextbookassets 

To do: Add media to "competency" page.
(Assignee)

Updated

4 years ago
Assignee: nobody → kat
(Assignee)

Comment 1

4 years ago
Created attachment 8458939 [details]
Media to be added (for review)
Attachment #8458939 - Flags: review?(matt)
(Assignee)

Comment 2

4 years ago
Also adding Claw and Cassie in case they have ideas about images/videos for this competency.
(Assignee)

Updated

4 years ago
Summary: Add media [images, videos] to "Competency" page → Add media [images, videos] to "Composing" page
Whiteboard: [resources] [aug8]
* This image is great: https://www.flickr.com/photos/thisisbossi/6876878214

* We *definitely* need workflow for including Popcorn videos on these pages. Essential. Thanks for pushing on that Kat.
Attachment #8458939 - Flags: review?(matt) → review+
* For additional images, could we add some screen grabs from "What Screens Want?" 

like
https://dl.dropboxusercontent.com/spa/6c38yp3crbxni5b/hquuuhlr.png

or this gif
http://frankchimero.com/talks/what-screens-want/transcript/burke17.gif

or there's other images and GIFs on that page as well
(Assignee)

Comment 5

4 years ago
Oooh, I *LOVE* that gif, Matt. 

And Aki, really sorry to bug you when you're busy, but when you have a moment, did you get a chance to add a shortcode for Popcorn videos within the JSON? I see examples for all other media types, but not Popcorn. Happy to embed direct links, but wanted to check first. 

Thank you!
Flags: needinfo?(aki)
(Assignee)

Comment 6

4 years ago
Update: 

* Discussion about Popcorn embeds has been moved to the [reopened] media embed syntax bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1032389(and this action will be delayed due to Aki's priority work on landing screens)

* Meanwhile, we can try adding these two images to the page if want, Matt? See new attachment for updated code.
Flags: needinfo?(aki)
(Assignee)

Comment 7

4 years ago
Created attachment 8460388 [details]
Media to be added (#2, for review)

2 images to be embedded -- one a smaller (but amazing) gif, the other a high-res Flickr image. 

Have added notes for attribution, and both images are uploaded to S3.
Flags: needinfo?(matt)
Attachment #8460388 - Flags: review+
Flags: needinfo?(matt)
(Assignee)

Comment 8

4 years ago
Created attachment 8461227 [details] [review]
Github pull request - content.json

Added image and gif under "composing" "discover" section as first sample bits of media for that page.
Attachment #8461227 - Flags: review?(aki)
Comment on attachment 8461227 [details] [review]
Github pull request - content.json

Just needs a little bit of work!
Attachment #8461227 - Flags: review?(aki) → review-
(Assignee)

Comment 10

4 years ago
Created attachment 8461758 [details]
Github pull request #2 - content.json

Tying to make suggested edits - but wasn't sure about the last one. Is this right?
Attachment #8461758 - Flags: review?(aki)
(Assignee)

Comment 11

4 years ago
Created attachment 8461915 [details]
Github pull request #3 - content.json

Fixed spacing on line 656 (i think!)
Attachment #8461915 - Flags: review?(aki)
Attachment #8461758 - Flags: review?(aki) → review+

Comment 12

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/ef8207de5ade4a379df87b595fae7159e9a6e01c
Merge pull request #904 from keyboardkat/patch-17

Fixes Bug 1040953 - Add media [images, videos] to "Composing" page

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment #8461915 - Flags: review?(aki) → review+
(Assignee)

Comment 13

4 years ago
Just wanted to check in on this. Haven't seen it go live yet. On production?
sorry Kat, looks like we haven't been awesome about pushing to production. pushing to staging right now, we'll do a little testing, then push to prod in a bit.
(Assignee)

Comment 15

4 years ago
Thanks for letting me know, Aki! I mostly just wanted to see our first Textbook image set looks on the site - wish I had a better way to preview this :)
okie dokie, we're good!
(Assignee)

Comment 17

4 years ago
Great, thanks Aki! One last edit before I share this page with others -- embedding a Popcorn video. Will submit PR now!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

4 years ago
Resolving again for now; Popcorn embeds not possible in "Make" yet, so we've gone as far as we can for now. Have filed for this change in https://bugzilla.mozilla.org/show_bug.cgi?id=1034371 .
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.