1040981 - [B2G][Browser] While in landscape mode the 'Default search engine' drop down is cut off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Josh Schmitt [Joshs]]

Attachment: log.txt

Description:
The 'Default search engine' drop down is cut off when in landscape mode.

Repro Steps:
1) Update a Flame to 20140718000232
2) Open Browser app
3) Select the Tabs list
4) Select the 'Gear' icon
5) Rotate to landscape

Actual:
The 'Default search engine drop down is not shown.

Expected:
The 'Default search engine' drop down is shown.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140718000232
Gaia: 34c24749e78496ac1317f4ddb573281c0ef2995e
Gecko: 76309f978531
Version: 32.0a2 (2.0)
Firmware Version: v122

User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: %,
See attached: screenshot, logcat

Comment 1

[Josh Schmitt [Joshs]]

Attachment: Landscape.png

Comment 2

[Peter Bylenga [:PBylenga]]

Qawanted for branch checks.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue does occur in 2.0 Flame, 2.1 Flame, and Buri 2.1.

Environmental Variables:
Device: Flame Master
BuildID: 20140718124617
Gaia: Unknown
Gecko: 50a8424cf1b8
Version: 33.0a1 (Master) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0


Environmental Variables:
Device: Flame 2.0
BuildID: 20140718135645
Gaia: 2f4b11611c9b37ccf33a76dbbe85cac912594253
Gecko: 12e11c8ecc0f
Version: 32.0a2 (2.0) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Buri Master
BuildID: 20140718061630
Gaia: Unknown
Gecko: 330ba968ed61
Version: 33.0a1 (Master) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

The default search engine dropdown is cut off the bottom.



Default search engine is not an option in Flame 1.4.

Environmental Variables:
Device: Flame 1.4
BuildID: 20140718081451
Gaia: 621d152f89347c79619aa909ad62cc2ac9d3ab5b
Gecko: 989db90b4457
Version: 30.0 (1.4) 
Firmware Version: v122
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 4

[Jason Smith [:jsmith]]

Is it possible to scroll down to the UI here when this bug reproduces to be able to change the default search engine?

Comment 5

[Joshua Mitchell (Inactive)]

(In reply to Jason Smith [:jsmith] from comment #4)
> Is it possible to scroll down to the UI here when this bug reproduces to be
> able to change the default search engine?

No, the user is not able to scroll down. 
As shown in attachment in comment 1 the top part of the selection box can be seen and if you click on that you will be taken to the search engine selection screen with the 3 engines and be able to select them but most users might not realize that that is the function of the partially seen box.

Comment 6

[Jason Smith [:jsmith]]

Josh - Can you provide a blocking triage analysis here?

Comment 7

[Joshua Mitchell (Inactive)]

triage analysis - would not block on this issue, User has to be in landscape mode to see bug (lower visibility), default search engine is not something that will be changed often, if at all (lower visibility), and the issue is not critical - the button is "cut off" but not off the screen entirely.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #7)
> triage analysis - would not block on this issue, User has to be in landscape
> mode to see bug (lower visibility), default search engine is not something
> that will be changed often, if at all (lower visibility), and the issue is
> not critical - the button is "cut off" but not off the screen entirely.

In terms of product requirements, landscape & default search engine are user workflows that we should support though based on our feature needs for the release. I'm also concerned that the user might not even realize that the search engine is possible to change here in landscape, as a large amount of the UX isn't shown here that gives the user indication that something is clickable here.

UX - Can you weigh in here if this is a blocker from your perspective?

Comment 9

[Stephany Wilkes]

The inability to scroll is what makes me think this is a blocker. If the user could scroll, I'd not block on the rest for many of the reasons Jason has stated.

Comment 10

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: comment 8 and comment 9

Comment 11

[Jason Smith [:jsmith]]

Blocking per comment 9.

Comment 12

[Manuel Casas Barrado [:mancas]]

Attachment: Settings screen is now scrollable

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8469082 [details] [review]
Settings screen is now scrollable

Thanks for the patch! I will take over as reviewer since both Ben and Dale are out, this looks pretty simple, and I was asked to.

Comment 14

[Kevin Grandon :kgrandon]

I've rebased to add the correct reviewer name and this is now landed.

Master: https://github.com/mozilla-b2g/gaia/commit/4c2789abd474a993c409b081550d0a2213392ebd
v2.0: https://github.com/mozilla-b2g/gaia/commit/87504d52776b46795057ab09f625e1177fa46fe1

Comment 15

[Paladin]

This issue has been verified successfully on Flame 2.0

See attachment: Verify_video.3gp
Reproducing rate: 0/5
FLame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

There is no Settings button in Browser,so we can't verify it in Flame 2.1.
Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0

Comment 16

[Paladin]

Attachment: Verify_video.3gp