Doorhangers overflow off the screen if their buttons are placed too far right on the toolbar in maximized mode

UNCONFIRMED
Unassigned

Status

()

Firefox
Toolbars and Customization
UNCONFIRMED
4 years ago
3 years ago

People

(Reporter: jaramat, Unassigned)

Tracking

Trunk
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8459035 [details]
widget-overflow.png

STEPS TO REPRODUCE:
1. Open the Customize mode and place any button that spawns an Australis-styled doorhanger menulist to the far right of the bookmarks bar or tab bar
2. Exit the Customize mode and maximize Firefox window
3. Click the new button on the far right

EXPECTED RESULTS:
The doorhanger opens and is 100% visible on the screen

ACTUAL RESULTS:
The doorhanger opens, but its right side is out of the screen and thus is not visible

AFFECTED WIDGETS:
#developer-button, #characterencoding-button, #downloads-button, #sidebar-button, #feed-button, #downloads-button, #history-panelmenu
Bookmarks Menu button is unaffected. 

POSSIBLE FIX:
This could be fixed for example by adding a right margin to the affected toolbars:

window[sizemode="maximized"]:not([customizing="true"]) :-moz-any(#TabsToolbar, #PersonalToolbar) {
  margin-right: 9px;
}

Comment 1

4 years ago
Has this been broken since 29 or is this a regression of sorts? We fixed e.g. bug 949092 so I kind of thought we were done with these...
Component: General → Toolbars and Customization
Flags: needinfo?(jaramat)
(Reporter)

Comment 2

4 years ago
Created attachment 8460602 [details]
doorhanger-overflow.png

(In reply to :Gijs Kruitbosch (Gone July 26 - August 3) from comment #1)

This has been broken since 29.

If a button that spawns a doorhanger is placed at the far right of the tabs toolbar or bookmarks bar, then the doorhanger is drawn over the window's border. When the window is maximized, the doorhanger is cut off.

Attached picture:
Frame 1 - #developer-button: The panel is cut off.
Frame 2 - #PanelUI-button: There is no problem here. There's a 5px space between the panel and the screen edge.
Frame 3 - #characterencoding-button: The panel is cut off.
Flags: needinfo?(jaramat)
You need to log in before you can comment on or make changes to this bug.