remove space from email addresses in flag update messages

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hi, Assigned: glob)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

Sat in #firefox on MozNet



Actual results:

Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?
Random question mark on the cancelled messages, e-mail repeated in brackets etc.
(oh, and my username is 'c' so it pings me)

user@domain.com requested needinfo from otheruser@domain.c om on bug 123456.
user@domain.com cancelled needinfo?(user@domain.c om) on bug 123456.


Expected results:

user@domain.com requested needinfo from otheruser@domain.com on bug 123456.
user@domain.com cancelled needinfo on bug 123456.
(Assignee)

Comment 1

4 years ago
> Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?

i'll investigate where this comes from.  it's probably an artefact of unwrapping bugmail.

> Random question mark on the cancelled messages, e-mail repeated in brackets

the question marks are not "random" - they indicate the status of the flag, and the email in the brackets are the requestee.
"needinfo?(user@example.com)" means the needinfo request directed at user@exmaple.com was cleared

i won't be changing this output.
Assignee: nobody → glob
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: Grammar errors with Firebot → remove space from email addresses in flag update messages
(Assignee)

Comment 2

4 years ago
unwrapping was indeed the issue.

https://github.com/globau/firebot/commit/8aba6c25b5c2a24fbf2c79d59e763cf25eefd1b3
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

4 years ago
(In reply to Byron Jones ‹:glob› from comment #1)
> > Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?
> 
> i'll investigate where this comes from.  it's probably an artefact of
> unwrapping bugmail.
> 
> > Random question mark on the cancelled messages, e-mail repeated in brackets
> 
> the question marks are not "random" - they indicate the status of the flag,
> and the email in the brackets are the requestee.
> "needinfo?(user@example.com)" means the needinfo request directed at
> user@exmaple.com was cleared
> 
> i won't be changing this output.

Alright, there needs to be a space after the ? though
(Assignee)

Comment 4

4 years ago
(In reply to Chip from comment #3)
> Alright, there needs to be a space after the ? though

flags are displayed in bugzilla as needinfo?(user@example.com); there's no reason for firebot to deviate from this.
You need to log in before you can comment on or make changes to this bug.