1041102 - remove space from email addresses in flag update messages

Status: RESOLVED FIXED

(Webtools Graveyard :: Mozbot, defect)

Description

[Chip]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

Sat in #firefox on MozNet



Actual results:

Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?
Random question mark on the cancelled messages, e-mail repeated in brackets etc.
(oh, and my username is 'c' so it pings me)

[e-mail] requested needinfo from otheruser@domain.c om on bug 123456.
[e-mail] cancelled needinfo?(user@domain.c om) on bug 123456.


Expected results:

[e-mail] requested needinfo from [e-mail] on bug 123456.
[e-mail] cancelled needinfo on bug 123456.

Comment 1

[:glob ✱]

> Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?

i'll investigate where this comes from.  it's probably an artefact of unwrapping bugmail.

> Random question mark on the cancelled messages, e-mail repeated in brackets

the question marks are not "random" - they indicate the status of the flag, and the email in the brackets are the requestee.
"needinfo?([e-mail])" means the needinfo request directed at [e-mail] was cleared

i won't be changing this output.

Comment 2

[:glob ✱]

unwrapping was indeed the issue.

https://github.com/globau/firebot/commit/8aba6c25b5c2a24fbf2c79d59e763cf25eefd1b3

Comment 3

[Chip]

(In reply to Byron Jones ‹:glob› from comment #1)
> > Firebot puts spaces in e-mail addresses, supposedly anonymizing the address?
> 
> i'll investigate where this comes from.  it's probably an artefact of
> unwrapping bugmail.
> 
> > Random question mark on the cancelled messages, e-mail repeated in brackets
> 
> the question marks are not "random" - they indicate the status of the flag,
> and the email in the brackets are the requestee.
> "needinfo?([e-mail])" means the needinfo request directed at
> [e-mail] was cleared
> 
> i won't be changing this output.

Alright, there needs to be a space after the ? though

Comment 4

[:glob ✱]

(In reply to Chip from comment #3)
> Alright, there needs to be a space after the ? though

flags are displayed in bugzilla as needinfo?([e-mail]); there's no reason for firebot to deviate from this.