Closed Bug 104112 Opened 24 years ago Closed 24 years ago

[BRANCH 0.9.4]HoTMetaL doctype should trigger quirks mode

Categories

(Core :: DOM: HTML Parser, defect, P1)

Product:
Core
Component:
DOM: HTML Parser
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
VERIFIED WONTFIX
Milestone:
mozilla0.9.6

People

(Reporter: harishd, Assigned: harishd)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [Need ETA][fix in hand][bugscape 9924] [PDT-])

Attachments

(2 files)

patch v1.0 [ Should be applied only to the branch ]
1.77 KB, patch
hjtoi-bugzilla
: review+
vidur
: superreview+
Details | Diff | Splinter Review
patch v1.2 [ includes heikki's and vidur's concern ]
1.71 KB, patch
Details | Diff | Splinter Review
<!DOCTYPE HTML PUBLIC "-//SoftQuad//DTD HoTMetaL PRO 4.0::19971010::extensions to HTML 4.0//EN" "hmpro4.dtd"> should trigger quriks mode in the branch.
wasn't this fixed in bug 102442? Or was that branch only?
Since the trunk has the new doctype detection code, dbaron's patch ( bug 102442 ) got checked in only on the *trunk*.
pls explain why this would be needed on the 094 branch, this late in the game (i.e. loss of functionality, dataloss, hand, etc.).
URL: [Need ETA]
Whiteboard: [Need ETA]
David Baron checked in a fix on the trunk to make this DOCTYPE trigger quirks mode. However, DOCTYPE detection code in the branch is a different code altogether ( though I was under the impression that the DOCTYPE detection changes landed on the branch as well - bug 55264 ) and hence still triggers strict mode.
Priority: -- → P1
Whiteboard: [Need ETA] → [Need ETA][fix in hand]
Target Milestone: --- → mozilla0.9.6
Comment on attachment 52966 [details] [diff] [review] patch v1.0 [ Should be applied only to the branch ] r=heikki, although I would suggest a few small changes: in addition to mentioning Bugscape bug number, please mention this Bugzilla bug; replace -1 with kNotFound.
Attachment #52966 - Flags: review+
We should take this fix when its ready if the impact is restricted to SoftQuad HTML HoTMetaL is one of only a few html authoring tools and they are open source friendly. Fixing them should fix a number of sites using their tools and will help to maintain good relations.
Bugscape 9924. If we get the opportunity, I'd like to get this in, nsbranch+.
Keywords: nsbranch → nsbranch+
Summary: HoTMetaL doctype should trigger quirks mode → [BRANCH 0.9.4]HoTMetaL doctype should trigger quirks mode
Whiteboard: [Need ETA][fix in hand] → [Need ETA][fix in hand][bugscape 9924]
can we test some site to see how often this doctype is used, and/or if we affect any other sites, by taking this fix.
Keywords: regression
Comment on attachment 52966 [details] [diff] [review] patch v1.0 [ Should be applied only to the branch ] sr=vidur
Attachment #52966 - Flags: superreview+
pls get r/sr= on the new patch.
I tried the index pages for the top 100 sites, and 3228 pages linked to them, and none of these pages are using the DOCTYPE HTML PUBLIC //SoftQuad//DTD; but there are few sites online, mostly there are users personal web pages, with <!DOCTYPE HTML PUBLIC "-//SoftQuad//DTD HoTMetaL PRO 4.0::19970714::extensions to HTML 4.0//EN" "hmpro4.dtd"> http://www.rotary7120.org/ http://members.tripod.com/~Yossi_Barad/beer.html http://www.csulb.edu/depts/dss/wkable.html http://www.cbs.dk/stud_serv/studdk.shtml http://homepages.tesco.net/~stneots/Page1.html http://freespace.virgin.net/adrian.ball/ecuador.htm http://www.med.univ-angers.fr/discipline/lab_hema/assbioprat1.html http://ipac.deusto.es/CDROMS/imprenta.htm http://www.geocities.com/customdolls_2000/ http://www.bizcompr.com/news/news.htm http://www.bizcompr.com/news/masterfranchising.htm http://www.countrymusicfestival.com/kheadhuntersbio.htm http://www.westhoughton1.freeserve.co.uk/dunardry/dunardry.htm http://www.bnv-gz.de/~srk/index4.htm HTML Elements are not laid out properly on some of these pages. The browser is failing very differently on each page, and similar failures happen on IE.
We seem to only break some pages, in different ways, but the code on these pages aren't standards compliant, so we are gonna stand were we are until we get more information = PDT-
Whiteboard: [Need ETA][fix in hand][bugscape 9924] → [Need ETA][fix in hand][bugscape 9924] [PDT-]
This seems to need some evang lovin'
After discussing with PDT we have decided to not change the existing behavior.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WONTFIX
Marking verified as per harishd's comment.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: