Unable to add an app to the Featured app and accompanying error message is vague

VERIFIED FIXED

Status

P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: krupa.mozbugs, Assigned: chuck)

Tracking

x86
Mac OS X
Points:
---

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8459206 [details]
unable to add an app.png

+++ This bug was initially created as a clone of Bug #1040990 +++

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curate/create/apps
2. Search for "facebook"
3. Add the other required fields and click Save

expected behavior:
1. App is added and shows up in the Feed preview
2. Error message is clear and accurate

observed behavior:
App is not added and doesn't show up in the Feed Preview
The error message upon clicking "submit" says 'This field is required' which doesn't specify what field is missing
(Reporter)

Comment 1

4 years ago
Same thing happens for collections as well. Form submissions results in a 400.
Priority: P2 → P1
(Assignee)

Comment 2

4 years ago
There are a few bugs here.

The first is that the preview wasn't updating when an app is selected. I just addressed that here:

https://github.com/mozilla/transonic/pull/18

The second is the validation error, which is likely a field whose name was lost in the UX sweep. Let's make this bug about that. I'll take it.

The third is that error messages don't have a very good presentation right now. Can you file a separate bug for that, Krupa?
Assignee: nobody → charmston
Priority: P1 → P2
(Assignee)

Comment 3

4 years ago
The second bug addressed here: https://github.com/mozilla/transonic/compare/6c91a50ff495...be6b4a988b70
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

4 years ago
(In reply to Chuck Harmston [:chuck] from comment #2)

> The third is that error messages don't have a very good presentation right
> now. Can you file a separate bug for that, Krupa?

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1041699
No longer blocks: 1037045
(Reporter)

Comment 5

4 years ago
verified fixed at https://marketplace-dev.allizom.org/curate/manage/collections/000~
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.