The bitmask enums flags calculation for getBitToEnumValue is flawed

RESOLVED FIXED in Firefox 34

Status

()

Firefox
Developer Tools: Canvas Debugger
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 34
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
getBitToEnumValue("gl", ctx, ctx.TEXTURE_2D)
results in
"ONE | DEPTH_BUFFER_BIT | STENCIL_BUFFER_BIT | CW | CCW"
not
"TEXTURE_2D"

This happens most likely because a faulty regex.
(Assignee)

Comment 1

4 years ago
Created attachment 8459244 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8459244 - Flags: review?(jsantell)
Comment on attachment 8459244 [details] [diff] [review]
v1

Review of attachment 8459244 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #8459244 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/7a250901c59d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.