Closed Bug 1041256 Opened 10 years ago Closed 10 years ago

logging used but not imported in extension.py

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Version:
Development/Staging
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

References

Details

logging.error() is called in two places in rbbz/extension.py, but it's not imported.  A simple fix, but I'm not sure if the logging module is configured to actually write to somewhere, e.g. the web server logs.  The docs on extensions don't appear to mention logging.
We should at least investigate this before launching.  If this works through some sort of magic, it should at least be documented somewhere, like in the file.
Blocks: 1021929
Looks like logging is configured to work in the dev server at least.  A simple import to fix it (and removed logging import from models.py, where it isn't used).

http://hg.mozilla.org/hgcustom/version-control-tools/rev/23f0d592a392
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: bugzilla.mozilla.org → Developer Services
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.