Closed Bug 1041298 Opened 7 years ago Closed 7 years ago

browser_ruleview_keyframes-rule_02.js | Added top property should have been used. - Got 120px, expected 750px

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox32 unaffected, firefox33 fixed, firefox34 fixed, firefox-esr24 unaffected, firefox-esr31 unaffected)

RESOLVED FIXED
Firefox 34
Tracking Status
firefox32 --- unaffected
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- unaffected

People

(Reporter: miker, Assigned: gl)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → gabriel.luong
Attached patch 1041298.patch (obsolete) — Splinter Review
Increasing the animation time. https://tbpl.mozilla.org/?tree=Try&rev=d45a22f37282
Comment on attachment 8460635 [details] [diff] [review]
1041298.patch

Review of attachment 8460635 [details] [diff] [review]:
-----------------------------------------------------------------

Ran multiple dt tests for opt builds and no intermittent failures were reported. Increasing the duration time should hopefully fix this.
Attachment #8460635 - Flags: review?(fayearthur)
Comment on attachment 8460635 [details] [diff] [review]
1041298.patch

Review of attachment 8460635 [details] [diff] [review]:
-----------------------------------------------------------------

Hm. 15s is such a long time already. And given that these are opt builds that are failing, it's not like the properties weren't edited in time.

This seems like it might be catching an actual bug in the platform not picking up changes during animations. Another option could be adding an animation-delay, but we could try this.
Attachment #8460635 - Flags: review?(fayearthur) → review+
Attached patch 1041298-2.patchSplinter Review
Removed the test for top 

try: https://tbpl.mozilla.org/?tree=Try&rev=006c5f1992f0
Attachment #8461226 - Flags: review?(fayearthur)
Attachment #8461226 - Flags: review?(fayearthur) → review+
Attachment #8460635 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/edfd65cef207
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Filed bug 1050825 for the instance in comment 48.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.