1041346 - MP4Demuxer should not limit number of output samples

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

The stagefright MP4 demuxer limits the number of output samples it produces to 1 at a time. This is annoying, as the MP4Reader tries to input mulitple samples into its MediaDataDecoder, and if the MediaDataDecoder needs to buffer them for some reason this will cause the decode task queue to block waiting for the MediaDataDecoder to release its sample, but if the MediaDataDecoder requires dispatching something to the decode task queue it will fail because the decode task queue is blocked in MP4Demuxer::Demux() waiting for a sample to be made available and deadlock.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8459346 [details] [diff] [review]
Patch

Review of attachment 8459346 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Can we remove MediaBufferGroup altogether?

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch : Remove mediabuffergroup

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/771dea9531b4
https://hg.mozilla.org/integration/mozilla-inbound/rev/463dfcb4901a

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/771dea9531b4
https://hg.mozilla.org/mozilla-central/rev/463dfcb4901a