Closed
Bug 1041401
Opened 10 years ago
Closed 10 years ago
Build WMF PDM in its own translation unit
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
3.62 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
Sometimes when I add files to content/media/fmp4 it changes the files that are built with the WMF PDM. This means that Windows.h can be included in a file before WMF.h, which breaks the build. Also, sometimes the definition of min and max macros in Windows.h breaks the use of std::min/max in gfx headers that WMF includes, so we need to undef those in WMF.h too.
Attachment #8459410 -
Flags: review?(paul)
|
||
Updated•10 years ago
|
Attachment #8459410 -
Flags: review?(paul) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4d21d66091a
|
||
Comment 2•10 years ago
|
||
No build peer review?
|
|
Assignee | |
Comment 3•10 years ago
|
||
Why would we need a build peer review for such a trivial change?
https://hg.mozilla.org/mozilla-central/rev/d4d21d66091a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•