1041420 - Failures in all mozmill tests that uses localhost address

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Daniel Gherasim]

Starting with 19 July our remote/functional testruns started to fail due to some regressions regarding URL typing.

Tests that fail:
functional:
> /testSearch/testSearchSuggestions.js
> /testSearch/testSearchViaFocus.js
> /testSearch/testSearchViaShortcut.js
> /testSecurity/testEnablePrivilege.js
remote:
> /testGeolocation/testAlwaysShareLocation.js
> /testGeolocation/testNeverShareLocation.js
> /testSecurity/testGreenLarry.js
> /testSecurity/testSafeBrowsingNotificationBar.js
> /testSecurity/testSecurityInfoViaMoreInformation.js	
> /testSecurity/testSecurityNotification.js


Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=99f694d1b50c&tochange=35f3fa435d2c

Looks like all tests that fail uses "localhost" which is automatically changed into "www.localhost" which is not working. 

Will do regression range now to find exactly what changed.

Comment 1

[Daniel Gherasim]

Tinderbox pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e5eb00a12e9&tochange=9fdb8047f07d

Nothing pops out to me. I'll continue with inbound pushlog.

Comment 2

[Daniel Gherasim]

Here is the pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c57608929ef7&tochange=b786f0b2d1bd

Bug 354493 seems to cause this. I'll continue the investigation.

Comment 3

[Daniel Gherasim]

Attachment: testcase.js

Here is a simple testcase.
The page is not correctly loaded because www. is automatically added to 'localhost:43336/...'

Steve, any idea how your patch could affect here ?

Comment 4

[Daniel Gherasim]

We can skip all the tests (may be more then this) or do a workaround by setting browser.fixup.alternate.enabled to false in all tests that uses localhost.

Comment 5

[Daniel Gherasim]

It actually replaces : "localhost:43336/..." with "www.localhost.com:43336/...".

I can manually reproduce this ! : 

1. Installed LAMP on ubuntu
2. Changed the port of apache to 8181
3. Typed localhost:8181 in the urlbar
4. URL replaced with www.localhost.com:8181
5. Page fails to load.

Comment 6

[Daniel Gherasim]

Note about above steps: Accessing localhost:8181 while we already are in 'about:newtab', 'about:blank' or any other local page works and the link doesn't get alterneted. We get this only if we are already on a remote page and we are trying to change the address to localhost.

Comment 7

[Daniel Gherasim]

I really don't think that that's the default behavior we want in firefox (e.g. we may want to access 'localhost:port' while we are on a home page that most likely can be remote), but if that's what we want, I see 2 solutions here for us (workaround if that's not the default behavior or fix if that is really what we want):

1. Initially set network.zonepolicy.enabled to false for out tests.
2. Ensure we are accessing localhost while we are already on local page.

Dave, any suggestion about this and should we go with one of the above steps ?

Comment 8

[Andreea Matei [:AndreeaMatei]]

We need to skip these tests until it's getting fixed.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

If you can replicate this manually then it sounds like a bug in Firefox. Please raise this bug and mark it as blocking. For now, we can skip these tests.

Comment 10

[Daniel Gherasim]

Attachment: skip-remote-functional.patch

http://mozmill-crowd.blargon7.com/#/functional/report/68ae90e16718c6da68596418407508e0
http://mozmill-crowd.blargon7.com/#/remote/report/68ae90e16718c6da685964184073a1ed

Comment 11

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8459541 [details] [diff] [review]
skip-remote-functional.patch

Review of attachment 8459541 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled: 
http://hg.mozilla.org/qa/mozmill-tests/rev/4074bdcad41a (default)

Comment 12

[Daniel Gherasim]

Filed bug 1041511 for this. Needinfo moved there.

Comment 13

[Daniel Gherasim]

The dependency bug that caused this (bug 354493) was backed out from nightly and will be backed out from aurora too so we will be able to unskip this tests safely.

Comment 14

[Andrei Eftimie]

Did a full testrun, everything works great.

Backed out skip from Nightly:
https://hg.mozilla.org/qa/mozmill-tests/rev/426fe8da5da1 (default)

Comment 16

[Daniel Gherasim]

We can backout the skip from aurora now:

http://mozmill-crowd.blargon7.com/#/functional/report/533154d2e18fa05bbdf2eaada846216c
http://mozmill-crowd.blargon7.com/#/remote/report/533154d2e18fa05bbdf2eaada846516b

Comment 17

[Andrei Eftimie]

Backed out skip from aurora as well:
https://hg.mozilla.org/qa/mozmill-tests/rev/ba2f6db3107d (mozilla-aurora)