Closed Bug 1041514 Opened 5 years ago Closed 4 years ago

Don't show default browser prompt on first run if a user opts out in the installer

Categories

(Firefox :: General, defect, P2)

32 Branch
x86
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 47
Tracking Status
firefox47 --- verified

People

(Reporter: verdi, Assigned: jaws)

References

(Blocks 3 open bugs, )

Details

(Whiteboard: [fxgrowth] [qx:spec][Onboarding])

Attachments

(1 file, 1 obsolete file)

On Windows XP, Vista and 7 we have "make Firefox my default browser" checkbox in the installer that is checked by default. If a user unchecks this and proceeds with the installation they will see a prompt when Firefox opens asking if they want to make Firefox the default browser. We should respect the choice they made in the installer and not show the prompt on startup in this case.
Whiteboard: [fxgrowth]
Flags: firefox-backlog+
Blocks: 1062896
We probably don't want to drop the prompt entirely for those users, but just delay it until they start Firefox the next time. Basically treating unchecking the box in the installer as a a »not now«.
Flags: qe-verify+
Depends on: 1088912
Blocks: 1142762
Whiteboard: [fxgrowth] [qx] → [fxgrowth] [qx:spec]
Blocks: 1129599
Blocks: qx-onboarding
No longer blocks: 1129599
Whiteboard: [fxgrowth] [qx:spec] → [fxgrowth] [qx:spec][Onboarding]
Depends on: 1238712
Priority: -- → P3
Attached patch Patch (obsolete) — Splinter Review
Is there a way to write to the preferences directly from the installer so I don't need to go through the Registry?

I wrote to HKLM\Software\mozilla.org\Mozilla because it was easily predictable on the Firefox-application side, but I see other code in the installer writes to HKLM\Software\Mozilla (http://mxr.mozilla.org/mozilla-central/source/browser/installer/windows/nsis/installer.nsi#341)

Also, this patch doesn't show the dialog in subsequent launches of Firefox after first-run. I plan to do something about that in bug 1143116.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8711969 - Flags: review?(robert.strong.bugs)
Comment on attachment 8711969 [details] [diff] [review]
Patch

There is no way for NSIS to write Mozilla style preferences.

I think it would be much better to go with writing to HKCU, remove the registry entry, and set the Firefox preference.

For the registry entry it would be better to go with HKCU\Software\Mozilla\Firefox

Note: it should also remove empty hives when the registry entry exists and it is removed.
Attachment #8711969 - Flags: review?(robert.strong.bugs) → review-
Blocks: 1247818
No longer blocks: fx-qx
Attachment #8711969 - Attachment is obsolete: true
Comment on attachment 8720626 [details]
MozReview Request: Bug 1041514 - Don't show default browser prompt if a user opts out in the installer. r?jimm

https://reviewboard.mozilla.org/r/35389/#review32457
Attachment #8720626 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/fx-team/rev/897d193994904c5fc5fb3d16f3b3a18d2f2d420d
Bug 1041514 - Don't show default browser prompt if a user opts out in the installer. r=jimm
https://hg.mozilla.org/mozilla-central/rev/897d19399490
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Verified fixed on Windows 7 64bit and Windows Vista 32bit using latest Nightly 47.0a1 (buildID: 20160302030209): the prompt asking if you want to make Firefox the default browser doesn't appear anymore, after unchecking "make Firefox my default browser" checkbox in the installer. 

Only one mention here: when I launch Firefox after installation, in the about:preferences -> General tab -> the "Always check if Nightly is your default browser" is unchecked by default. Then, I close Firefox and reopen it with a new profile and now, the "Always check if Nightly is your default browser" is checked by default. It is expected behaviour?
Flags: needinfo?(jaws)
Yeah this is expected behavior. The installer only knows about the first profile it creates and we don't have a way to inherit settings from existing profiles to new profiles (by design).
Flags: needinfo?(jaws)
Thank you!

Marking VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.